Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Processes tab test change: Wait for page loading #165303

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[Infra UI] Processes tab test change: Wait for page loading #165303

merged 1 commit into from
Sep 1, 2023

Conversation

jennypavlova
Copy link
Member

Related to #160796

Summary

This PR adds the change explained here in the new node details page tests.

@jennypavlova jennypavlova added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 31, 2023
@jennypavlova jennypavlova self-assigned this Aug 31, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova jennypavlova mentioned this pull request Aug 31, 2023
Closed
@jennypavlova jennypavlova marked this pull request as ready for review August 31, 2023 09:57
@jennypavlova jennypavlova requested a review from a team as a code owner August 31, 2023 09:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova linked an issue Aug 31, 2023 that may be closed by this pull request
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/infra/hosts_view·ts - InfraOps App Metrics UI Hosts View #Single host Flyout Processes Tab should render processes tab and with Total Value summary #160796
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

mykolaharmash
mykolaharmash reviewed Aug 31, 2023
View reviewed changes
x-pack/test/functional/apps/infra/node_details.ts
@@ -233,6 +233,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Processes Tab', () => {
before(async () => {
await pageObjects.assetDetails.clickProcessesTab();
await pageObjects.header.waitUntilLoadingHasFinished();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to add the same thing for other tabs as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it when initially loading the page - in theory, repeating this is not needed for most cases there is also a timeout so it shouldn't reach it. Here we are checking the content of an element that is still not available which results in having an empty string as value - I guess because we use getVisibleText ( the other tabs we check the elements directly and here we try to get the content of an element which is still not loaded)
I am not against having this in the other tabs but I don't see any failed tests in the other scenarios, maybe I am missing something or it's not an issue there 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it, good point about getVisibleText, that's probably the difference with other tabs and we don't need to add wait for them 🙌

mykolaharmash
mykolaharmash approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jennypavlova jennypavlova merged commit 38c3b85 into elastic:main Sep 1, 2023
@jennypavlova jennypavlova deleted the 160796-fix-flaky-test-processes-node-details branch September 1, 2023 09:10
@jennypavlova jennypavlova mentioned this pull request Sep 1, 2023
Merged
jennypavlova added a commit that referenced this pull request Sep 1, 2023
@jennypavlova
[Infra UI] Process tab flaky test fix- Wait for page loading (#165440)
7bb8667 
Closes #160796 

## Summary

As we see in the picture from the failed build we are trying to check
the values when there are still spinners on the screen (so the data is
still loading).

<img width="1791" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/94608e6b-21b1-4435-9cee-efbf5a57f4ac">


To fix that I am now waiting for the page to load. This PR will be
backported to fix the issue in 8.9 and I will add a follow-up PR
(#165303) for the same fix in node
details tests.


[Build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykolaharmash mykolaharmash mykolaharmash approved these changes

Assignees

@jennypavlova jennypavlova

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
6 participants
@jennypavlova @apmmachine @elasticmachine @kibana-ci @mykolaharmash @kibanamachine