[@kbn/handlebars] Simplify the way upstream changes are discovered #150024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
mistic
approved these changes
Feb 1, 2023
watson
commented
Feb 2, 2023
watson
commented
Feb 2, 2023
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 2, 2023
…lastic#150024) Previously a custom diff of the files inside the upstream `spec` directory was kept up-to-date in this package `.patches` directory. This process was very tedious and wasn't providing much value. In this commit I've simplified the process tremendously and simply rely on checking if there are any new commits upstream and then allow the developer to manually check for relevant changes. This is something they needed to do with the old system regardless. Here the code is just much simpler. --------- Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> (cherry picked from commit 9754529)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 2, 2023
…red (#150024) (#150142) # Backport This will backport the following commits from `main` to `8.6`: - [[@kbn/handlebars] Simplify the way upstream changes are discovered (#150024)](#150024) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Watson","email":"watson@elastic.co"},"sourceCommit":{"committedDate":"2023-02-02T09:56:56Z","message":"[@kbn/handlebars] Simplify the way upstream changes are discovered (#150024)\n\nPreviously a custom diff of the files inside the upstream `spec`\r\ndirectory was kept up-to-date in this package `.patches` directory. This\r\nprocess was very tedious and wasn't providing much value.\r\n\r\nIn this commit I've simplified the process tremendously and simply rely on\r\nchecking if there are any new commits upstream and then allow the\r\ndeveloper to manually check for relevant changes. This is something they\r\nneeded to do with the old system regardless. Here the code is just much\r\nsimpler.\r\n\r\n---------\r\n\r\nCo-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>","sha":"975452987919dff1dbfc1ae48100763385c09c36","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.7.0"],"number":150024,"url":"https://github.com/elastic/kibana/pull/150024","mergeCommit":{"message":"[@kbn/handlebars] Simplify the way upstream changes are discovered (#150024)\n\nPreviously a custom diff of the files inside the upstream `spec`\r\ndirectory was kept up-to-date in this package `.patches` directory. This\r\nprocess was very tedious and wasn't providing much value.\r\n\r\nIn this commit I've simplified the process tremendously and simply rely on\r\nchecking if there are any new commits upstream and then allow the\r\ndeveloper to manually check for relevant changes. This is something they\r\nneeded to do with the old system regardless. Here the code is just much\r\nsimpler.\r\n\r\n---------\r\n\r\nCo-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>","sha":"975452987919dff1dbfc1ae48100763385c09c36"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150024","number":150024,"mergeCommit":{"message":"[@kbn/handlebars] Simplify the way upstream changes are discovered (#150024)\n\nPreviously a custom diff of the files inside the upstream `spec`\r\ndirectory was kept up-to-date in this package `.patches` directory. This\r\nprocess was very tedious and wasn't providing much value.\r\n\r\nIn this commit I've simplified the process tremendously and simply rely on\r\nchecking if there are any new commits upstream and then allow the\r\ndeveloper to manually check for relevant changes. This is something they\r\nneeded to do with the old system regardless. Here the code is just much\r\nsimpler.\r\n\r\n---------\r\n\r\nCo-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>","sha":"975452987919dff1dbfc1ae48100763385c09c36"}}]}] BACKPORT--> Co-authored-by: Thomas Watson <watson@elastic.co>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…lastic#150024) Previously a custom diff of the files inside the upstream `spec` directory was kept up-to-date in this package `.patches` directory. This process was very tedious and wasn't providing much value. In this commit I've simplified the process tremendously and simply rely on checking if there are any new commits upstream and then allow the developer to manually check for relevant changes. This is something they needed to do with the old system regardless. Here the code is just much simpler. --------- Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a custom diff of the files inside the upstream
specdirectory was kept up-to-date in this package.patchesdirectory. This process was very tedious and wasn't providing much value.In this PR I've simplified the process tremendously and simply rely on checking if there are any new commits upstream and then allow the developer to manually check for relevant changes. This is something they needed to do with the old system regardless. Here the code is just much simpler.