Skip to content

Commit 9754529

Browse files
Thomas Watsonazasypkin
andauthored
[@kbn/handlebars] Simplify the way upstream changes are discovered (#150024)
Previously a custom diff of the files inside the upstream `spec` directory was kept up-to-date in this package `.patches` directory. This process was very tedious and wasn't providing much value. In this commit I've simplified the process tremendously and simply rely on checking if there are any new commits upstream and then allow the developer to manually check for relevant changes. This is something they needed to do with the old system regardless. Here the code is just much simpler. --------- Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
1 parent 418cad1 commit 9754529

33 files changed

+78
-5626
lines changed

.buildkite/scripts/steps/test/kbn_handlebars.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ set -euo pipefail
44

55
source .buildkite/scripts/common/util.sh
66

7-
echo '--- Checking for @kbn/handlebars test changes'
8-
packages/kbn-handlebars/scripts/check_for_test_changes.sh
7+
echo '--- Checking for @kbn/handlebars upstream updates'
8+
packages/kbn-handlebars/scripts/check_for_upstream_updates.sh

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ module.exports = {
518518
},
519519
},
520520
{
521-
files: ['packages/kbn-handlebars/src/upstream/**/*.{js,mjs,ts,tsx}'],
521+
files: ['packages/kbn-handlebars/src/spec/**/*.{js,mjs,ts,tsx}'],
522522
rules: {
523523
'@kbn/eslint/require-license-header': [
524524
'error',

packages/kbn-handlebars/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)