Skip to content

[Lens][Visualize][Embeddable] Optimize Lens embeddables on error #144015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 18, 2022
Merged

[Lens][Visualize][Embeddable] Optimize Lens embeddables on error #144015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
512859c
:bug: Reduce rerendering on expression error
dej611 Oct 26, 2022
cae7625
:wrench: Set complete also on error
dej611 Oct 26, 2022
30b1e9f
Merge branch 'main' into fix/143552
dej611 Oct 27, 2022
2463d6a
Merge remote-tracking branch 'upstream/main' into fix/143552
VladLasitsa Nov 15, 2022
cad6f55
Some updates
VladLasitsa Nov 15, 2022
735cea5
Merge branch 'main' into fix/143552
kibanamachine Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/plugins/kibana_utils/public/render_complete/render_complete_dispatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ export class RenderCompleteDispatcher {
}

public setEl(el?: HTMLElement) {
this.el = el;
this.count = 0;
if (this.el !== el) {
this.el = el;
this.count = 0;
}
if (el) this.dispatchInProgress();
}

Expand All @@ -61,7 +63,8 @@ export class RenderCompleteDispatcher {
public dispatchError() {
if (!this.el) return;
this.count++;
this.el.setAttribute('data-render-complete', 'false');
this.el.setAttribute('data-render-complete', 'true');
Copy link
Contributor

@alexwizp alexwizp Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@tsullivan tsullivan Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimkibana for followup work, we could accept an optional Error parameter, and use it to update the contents of a data-render-error attribute with a message. WDYT?

this.el.setAttribute('data-loading', 'false');
this.el.setAttribute('data-rendering-count', String(this.count));
}

Expand Down
15 changes: 12 additions & 3 deletions x-pack/plugins/lens/public/embeddable/embeddable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,9 @@ export class Embeddable
}

onContainerStateChanged(containerState: LensEmbeddableInput) {
if (this.handleContainerStateChanged(containerState) || this.errors?.length) this.reload();
if (this.handleContainerStateChanged(containerState)) {
this.reload();
}
}

handleContainerStateChanged(containerState: LensEmbeddableInput): boolean {
Expand Down Expand Up @@ -705,12 +707,19 @@ export class Embeddable

this.domNode.setAttribute('data-shared-item', '');

const error = this.getError();

this.updateOutput({
...this.getOutput(),
loading: true,
error: this.getError(),
error,
});
this.renderComplete.dispatchInProgress();

if (error) {
this.renderComplete.dispatchError();
} else {
this.renderComplete.dispatchInProgress();
}

const input = this.getInput();

Expand Down