[Reporting] Add new data-render-error attribute
#114472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
jloleysens
changed the title
data-render-error attribute
tsullivan
reviewed
Oct 11, 2021
| } | ||
| }); | ||
|
|
||
| return errorMessages; |
Member
There was a problem hiding this comment.
Seems like this should return undefined if there are no render errors, yes?
tsullivan
reviewed
Oct 11, 2021
| const errorMessages: string[] = []; | ||
|
|
||
| visualizations.forEach((visualization) => { | ||
| const errorMessage = visualization.getAttribute('data-render-error'); |
Member
There was a problem hiding this comment.
Couldn't a visualization possibly have elements with data-render-error but not match the layout.selectors.renderComplete selector? Seems like the render error selector should be independent of the render complete selector.
Also, there should be a [data-render-error] selector defined in the LayoutInstance, below here: https://github.com/elastic/kibana/blob/5957d31/x-pack/plugins/reporting/server/lib/layouts/index.ts#L35
tsullivan
reviewed
Oct 11, 2021
Comment on lines
102
to
107
| mergeMap(async () => { | ||
| // Read any data-render-error's so that users can be notified when something went wrong | ||
| return { | ||
| renderErrors: await getRenderErrors(driver, layout, logger), | ||
| }; | ||
| }), |
Member
There was a problem hiding this comment.
Suggested change
| mergeMap(async () => { | |
| // Read any data-render-error's so that users can be notified when something went wrong | |
| return { | |
| renderErrors: await getRenderErrors(driver, layout, logger), | |
| }; | |
| }), | |
| mergeMap(async () => ({ | |
| // Read any data-render-error's so that users can be notified when something went wrong | |
| renderErrors: await getRenderErrors(driver, layout, logger), | |
| })), |
tsullivan
reviewed
Oct 11, 2021
| interface ScreenSetupData { | ||
| elementsPositionAndAttributes: ElementsPositionAndAttribute[] | null; | ||
| timeRange: string | null; | ||
| renderErrors: string[]; |
Member
There was a problem hiding this comment.
Suggested change
| renderErrors: string[]; | |
| renderErrors?: string[]; |
tsullivan
reviewed
Oct 11, 2021
| elementsPositionAndAttributes: null, | ||
| timeRange: null, | ||
| error: err, | ||
| renderErrors: [], |
Member
There was a problem hiding this comment.
renderErrors should be optional and left out if it is empty
tsullivan
reviewed
Oct 11, 2021
Member
tsullivan
left a comment
tsullivan
left a comment
There was a problem hiding this comment.
Left a few comments about the changes
Member
|
These changes interact with #113807. The new |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
- make renderErrors optional in interfaces - create separate selectors for data render error selector/attr - Tidy up mergeMap behaviour
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/discover/_indexpattern_without_timefield·ts.discover app indexpattern without timefield should switch between with and without timefield using the browser back buttonStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 13, 2021
* added new data-render-error attribute, read it and store it on job object * added data-render-error to the example app * added jest test * address pr feedback - make renderErrors optional in interfaces - create separate selectors for data render error selector/attr - Tidy up mergeMap behaviour * fix observable.test.ts snapshots and browser driver mock * updated jest snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Oct 13, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 13, 2021
…ide-users-to-saving-ux * 'master' of github.com:elastic/kibana: (133 commits) [DOCS] Indicate reports are a subscription feature (elastic#114653) Update namespace for indices (elastic#114612) [DOCS] Adds Logstash pipeline settings (elastic#114648) Bump EPR snapshot version used for tests (elastic#114529) [Security Solution] [Endpoint] Fleet summary card adjustments (elastic#114291) skip flaky suite (elastic#68400) [Visualizations] fix usage of optional dependencies (elastic#114286) [Security Solution] [Detections] Improves custom query rule upgrade test (elastic#114454) [fleet] Add Integration Preference selector (elastic#114432) [Reporting] Add new `data-render-error` attribute (elastic#114472) Replace EuiCodeEditor with CodeEditor in app-services code (elastic#114316) [data views] add getDefaultDataView method (elastic#113891) [Security Solution] [Endpoint] Event filters uses the new card design (elastic#114126) [fleet] Tweak Header UI (elastic#114704) [APM] Filter on tx metrics for instance stats (elastic#114758) [APM] Fix typo in linting docs (elastic#114764) [Discover] Removing SavedObject usage for savedSearch (elastic#112983) [Fleet] Add Integration Policy Page Improvements (elastic#114556) [Lens] Keep the custom label when transitioning to/from Formula (elastic#114270) [Security Solution][Endpoint] Host Isolation API changes (elastic#113621) ...
jloleysens
added a commit
that referenced
this pull request
Oct 13, 2021
* added new data-render-error attribute, read it and store it on job object * added data-render-error to the example app * added jest test * address pr feedback - make renderErrors optional in interfaces - create separate selectors for data render error selector/attr - Tidy up mergeMap behaviour * fix observable.test.ts snapshots and browser driver mock * updated jest snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #113544.
We should close out #103561 after merging this new reporting functionality since these changes should enable improved UX for error reporting from App Services side.
How to test
--run-exampleswhen starting KibanaFollow up work
Once this is merged, we should be able to start working on: #104395 and close
Screenshots
Show render errors in report info panel
Checklist