-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens][Heatmap] Enables cursor syncronization #142821
Conversation
@markov00 @nickofthyme I need your help here. On the following gif I have an agg based heatmap (2nd chart) and a lens heatmap (3rd chart). Both charts share the same code but the hovering effect is visible only on the lens heatmap but not on the agg based. Can you understand why? |
Hey @stratoula, this is because Lens is setting kibana/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx Lines 757 to 759 in d778fa4
This prop on the UpdateThere was an error that created a difference in the behavior of the |
@nickofthyme thanx for the tip! You helped me to identify a bug #142954 So this means that the heatmap and the xy work differently right? In the XY even if I have the
although the tooltips are not synced, I can see the hovering but in heatmap in order to see the hovering effect this should be always set to true? |
No I agree this is a bug 🐛 that creates a difference in the behavior of the |
Pausing this until the fix on EC gets merged |
Updating EC with fix in #143103 |
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now, lets wait for datavis to add this on their side to complete the feature
Summary
Part of #138398
This PR enables cursor synchronization into the heatmap charts.
The tooltip synchronization doesn't work. I opened a feature request in EC repo elastic/elastic-charts#1844