Skip to content

Commit

Permalink
[Lens] Annotations design review (#140588)
Browse files Browse the repository at this point in the history
* feedback from Michael p1

* Update src/plugins/chart_expressions/expression_xy/public/components/annotations.tsx

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Apply suggestions from code review

Co-authored-by: Michael Marcialis <michael@marcial.is>

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* feedback

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* don't allow to dnd 1 element

* fix types

* Apply suggestions from code review

Co-authored-by: Michael Marcialis <michael@marcial.is>

* more suggestions

* linting

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Michael Marcialis <michael@marcial.is>
  • Loading branch information
3 people authored Sep 19, 2022
1 parent 8a47050 commit d778fa4
Show file tree
Hide file tree
Showing 15 changed files with 308 additions and 238 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import { AnnotationTooltipFormatter } from '@elastic/charts';
import { CustomAnnotationTooltip } from '@elastic/charts';
import {
AvailableAnnotationIcon,
ManualPointEventAnnotationArgs,
Expand All @@ -28,6 +28,6 @@ export interface MergedAnnotation extends Omit<ManualPointEventAnnotationArgs, '
timebucket: number;
position: 'bottom';
icon?: AvailableAnnotationIcon | string;
customTooltipDetails: AnnotationTooltipFormatter;
customTooltip: CustomAnnotationTooltip;
isGrouped: boolean;
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,45 @@
transform-origin: center;
}

.xyAnnotationTooltip {
border-radius: 0 !important;
}

.xyAnnotationTooltip__rows {
// max-height: 60vh;
overflow-y: hidden;
}

.xyAnnotationTooltipDetail {
padding: $euiSizeXS ($euiSizeXS * 2);
padding: $euiSizeXS (
$euiSizeXS * 2
);
}

.xyAnnotationTooltip__row {
font-weight: $euiFontWeightRegular;
padding: $euiSizeS $euiSizeM $euiSizeS $euiSizeS;
border-radius: 0 !important;
}

.xyAnnotationTooltip__extraFields {
color: $euiColorDarkShade;
margin-top: $euiSizeS;
}

.xyAnnotationTooltip__extraFieldsKey {
overflow-wrap: break-word;
hyphens: auto;
}

.xyAnnotationTooltip__extraFieldsValue {
text-align: right;
overflow-wrap: break-word;
hyphens: auto;
}

.xyAnnotationTooltip__skippedCount {
position: relative;
text-align: right;
font-weight: $euiFontWeightRegular;
}
Loading

0 comments on commit d778fa4

Please sign in to comment.