Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Enforce uniqueness by name instead of index pattern #136071

Merged
merged 17 commits into from
Jul 14, 2022
Merged

[data views] Enforce uniqueness by name instead of index pattern #136071

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b6e0bd3
data view uniqueness by name
mattkime Jul 10, 2022
4b19175
fix rest integration test
mattkime Jul 10, 2022
23987ae
fix createSavedObject findByName usage
mattkime Jul 12, 2022
79d6f92
Merge branch 'main' into data_view_uniqueness_by_name
mattkime Jul 12, 2022
ad7278d
fix rest integration test
mattkime Jul 12, 2022
6f4750e
fix rest integration test
mattkime Jul 12, 2022
d571cb2
fix previous mistake
mattkime Jul 12, 2022
c382f0e
Merge branch 'main' into data_view_uniqueness_by_name
mattkime Jul 13, 2022
cea9acc
global search provider should show name, not title/index pattern
mattkime Jul 13, 2022
232690e
Merge branch 'data_view_uniqueness_by_name' of github.com:mattkime/ki…
mattkime Jul 13, 2022
e4cf00e
cleanup
mattkime Jul 13, 2022
d786aa2
update index pattern saved object definition
mattkime Jul 13, 2022
b6fd2af
another try at fixing global search test
mattkime Jul 13, 2022
23f5d9c
fix global search
mattkime Jul 13, 2022
480c1de
add name to global search achived data
mattkime Jul 14, 2022
5c2c1ad
fix name field type
mattkime Jul 14, 2022
0426d18
minor improvements
mattkime Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update index pattern saved object definition
  • Loading branch information
@mattkime
mattkime committed Jul 13, 2022
commit d786aa2f83324f667fdbadd759ccf74c84b93643
4 changes: 2 additions & 2 deletions src/plugins/data_views/server/saved_objects/data_views.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ export const dataViewSavedObjectType: SavedObjectsType = {
management: {
displayName: 'data view',
icon: 'indexPatternApp',
defaultSearchField: 'title',
defaultSearchField: 'name',
importableAndExportable: true,
getTitle(obj) {
return obj.attributes.title;
return obj.attributes.name || obj.attributes.title;
},
getEditUrl(obj) {
return `/management/kibana/dataViews/dataView/${encodeURIComponent(obj.id)}`;
Expand Down