-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data views] Enforce uniqueness by name instead of index pattern #136071
[data views] Enforce uniqueness by name instead of index pattern #136071
Conversation
…bana into data_view_uniqueness_by_name
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this enforce uniqueness of names across spaces as well ?
@ppisljar No, at least I don't see a reason to enforce uniqueness across spaces, just within them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one NIT and one request
x-pack/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.ts
Show resolved
Hide resolved
x-pack/plugins/global_search_providers/server/providers/saved_objects/map_object_to_result.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
Summary
Data views can now be referenced by their name instead of their index pattern string. In the past, index pattern strings had to be unique since thats the way they were specified in the UI. Now we should keep their names unique instead of their index pattern strings.
Closes #135454