Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Enforce uniqueness by name instead of index pattern #136071

Merged
merged 17 commits into from
Jul 14, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jul 10, 2022

Summary

Data views can now be referenced by their name instead of their index pattern string. In the past, index pattern strings had to be unique since thats the way they were specified in the UI. Now we should keep their names unique instead of their index pattern strings.

Closes #135454

@mattkime mattkime changed the title data view uniqueness by name [data views] Enforce uniqueness by name instead of index pattern Jul 10, 2022
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages v8.4.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes labels Jul 10, 2022
@mattkime mattkime marked this pull request as ready for review July 13, 2022 02:20
@mattkime mattkime requested a review from a team as a code owner July 13, 2022 02:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this enforce uniqueness of names across spaces as well ?

@mattkime
Copy link
Contributor Author

@ppisljar No, at least I don't see a reason to enforce uniqueness across spaces, just within them.

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one NIT and one request

@mattkime mattkime enabled auto-merge (squash) July 14, 2022 11:56
@mattkime mattkime merged commit 9a4eca0 into elastic:main Jul 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 30.7KB 30.8KB +166.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
index-pattern 3 4 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Data view names unique instead of index patterns
6 participants