Final removal of all export default in ui/public

And turned on the eslint rule for that folder.

src/core_plugins/timelion/public/app.js

@@ -29,7 +29,8 @@ require('./vis');
 SavedObjectRegistryProvider.register(require('plugins/timelion/services/saved_sheet_register'));
 
 // TODO: Expose an api for dismissing notifications
-const unsafeNotifications = require('ui/notify').default._notifs;
+import { notify } from 'ui/notify';
+const unsafeNotifications = notify._notifs;
 
 require('ui/routes').enable();
 

src/ui/public/.eslintrc

@@ -1,2 +1,6 @@
+plugins: [
+  '@elastic/kibana-custom'
+]
 rules:
   no-console: 2
+  kibana-custom/no-default-export: error

src/ui/public/agg_types/index.js

@@ -99,6 +99,3 @@ export function AggTypesIndexProvider(Private) {
   });
 }
 
-export default AggTypesIndexProvider;
-
-// preload

src/ui/public/chrome/directives/kbn_chrome.js

@@ -8,7 +8,7 @@ import {
   getUnhashableStatesProvider,
   unhashUrl,
 } from 'ui/state_management/state_hashing';
-import Notifier from 'ui/notify';
+import { notify } from 'ui/notify';
 
 export function kbnChromeProvider(chrome, internals) {
 
@@ -56,7 +56,7 @@ export function kbnChromeProvider(chrome, internals) {
 
         // and some local values
         chrome.httpActive = $http.pendingRequests;
-        $scope.notifList = Notifier._notifs;
+        $scope.notifList = notify._notifs;
 
         return chrome;
       }

src/ui/public/doc_title/doc_title.js

@@ -43,5 +43,3 @@ export function DocTitleProvider(docTitle) {
   return docTitle;
 }
 
-// Default export used in x-pack. TODO: cleanup.
-export default DocTitleProvider;

src/ui/public/filter_bar/filter_bar_click_handler.js

@@ -68,5 +68,3 @@ export function FilterBarClickHandlerProvider(Notifier) {
   };
 }
 
-// Used in xpack. TODO: remove and cleanup.
-export default FilterBarClickHandlerProvider;

src/ui/public/filter_bar/query_filter.js

@@ -384,4 +384,3 @@ export function FilterBarQueryFilterProvider(Private, $rootScope, getAppState, g
   }
 }
 
-export default FilterBarQueryFilterProvider;

src/ui/public/filter_manager/filter_manager.js

@@ -85,5 +85,4 @@ export function FilterManagerProvider(Private) {
   return filterManager;
 }
 
-export default FilterManagerProvider;
 

src/ui/public/index_patterns/index_patterns.js

@@ -53,4 +53,3 @@ export function IndexPatternsProvider(esAdmin, Notifier, Private, Promise, kbnIn
 
 module.service('indexPatterns', Private => Private(IndexPatternsProvider));
 
-export default IndexPatternsProvider;

src/ui/public/management/index.js

@@ -20,5 +20,3 @@ management.register('kibana', {
   order: 20,
 });
 
-// Default export style used in x-pack. TODO: convert to named and remove.
-export default management;

src/ui/public/notify/notifier.js

@@ -662,5 +662,3 @@ function createGroupLogger(type, opts) {
   };
 }
 
-// Used in x-pack. TODO: convert to named and remove.
-export default Notifier;

src/ui/public/notify/notify.js

@@ -60,5 +60,3 @@ if (window.addEventListener) {
   });
 }
 
-// Used in x-pack. TODO: convert to named and remove.
-export default notify;

src/ui/public/registry/chrome_nav_controls.js

@@ -5,5 +5,3 @@ export const chromeNavControlsRegistry = uiRegistry({
   order: ['order']
 });
 
-// Used in x-pack. TODO: use named version and remove.
-export default chromeNavControlsRegistry;

src/ui/public/registry/dev_tools.js

@@ -6,4 +6,3 @@ export const DevToolsRegistryProvider = uiRegistry({
   order: ['order']
 });
 
-export default DevToolsRegistryProvider;

src/ui/public/registry/navbar_extensions.js

@@ -7,4 +7,3 @@ export const NavBarExtensionsRegistryProvider = uiRegistry({
   order: ['order']
 });
 
-export default NavBarExtensionsRegistryProvider;

src/ui/public/registry/vis_types.js

@@ -5,5 +5,3 @@ export const VisTypesRegistryProvider = uiRegistry({
   index: ['name'],
   order: ['title']
 });
-
-export default VisTypesRegistryProvider;

src/ui/public/saved_objects/saved_object_registry.js

@@ -5,5 +5,3 @@ export const SavedObjectRegistryProvider = uiRegistry({
   index: ['loaderProperties.name'],
   order: ['loaderProperties.name']
 });
-
-export default SavedObjectRegistryProvider;

src/ui/public/template_vis_type/template_vis_type.js

@@ -23,4 +23,3 @@ export function TemplateVisTypeProvider(Private) {
   return TemplateVisType;
 }
 
-export default TemplateVisTypeProvider;

src/ui/public/time_buckets/calc_es_interval.js

@@ -46,5 +46,3 @@ export function TimeBucketsCalcEsIntervalProvider() {
 
   return esDuration;
 }
-
-export default TimeBucketsCalcEsIntervalProvider;

src/ui/public/time_buckets/time_buckets.js

@@ -368,4 +368,3 @@ export function TimeBucketsProvider(Private, timefilter, config) {
   return TimeBuckets;
 }
 
-export default TimeBucketsProvider;

src/ui/public/utils/lodash-mixins/collection.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashCollectionMixin(_) {
   _.mixin(_, {
 
     /**

src/ui/public/utils/lodash-mixins/function.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashFunctionMixin(_) {
   _.mixin({
 
     /**

src/ui/public/utils/lodash-mixins/lang.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashLangMixin(_) {
   _.mixin(_, {
 
 

src/ui/public/utils/lodash-mixins/object.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashObjectMixin(_) {
   return _.mixin(_, {
 
     /**

src/ui/public/utils/lodash-mixins/oop.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashOopMixin(_) {
 
   // create a property descriptor for properties
   // that won't change

src/ui/public/utils/lodash-mixins/string.js

@@ -1,4 +1,4 @@
-export default function (_) {
+export function lodashStringMixin(_) {
 
   const DOT_PREFIX_RE = /(.).+?\./g;
 

src/ui/public/utils/parse_interval.js

@@ -32,5 +32,3 @@ export function parseInterval(interval) {
     return null;
   }
 }
-
-export default parseInterval;

src/ui/public/utils/scanner.js

@@ -73,4 +73,3 @@ Scanner.prototype.scanAndMap = function (searchString, options, mapFn) {
   });
 };
 
-export default Scanner;

src/ui/public/vis/schemas.js

@@ -62,4 +62,3 @@ export function VisSchemasProvider(Private) {
   return Schemas;
 }
 
-export default VisSchemasProvider;

webpackShims/lodash.js

@@ -5,11 +5,19 @@
  * var _ = require('lodash');
  */
 
-var _ = require('node_modules/lodash/index.js').runInContext();
-require('ui/utils/lodash-mixins/string')(_);
-require('ui/utils/lodash-mixins/lang')(_);
-require('ui/utils/lodash-mixins/object')(_);
-require('ui/utils/lodash-mixins/collection')(_);
-require('ui/utils/lodash-mixins/function')(_);
-require('ui/utils/lodash-mixins/oop')(_);
+const _ = require('node_modules/lodash/index.js').runInContext();
+const { lodashStringMixin } = require('ui/utils/lodash-mixins/string');
+const { lodashLangMixin } = require('ui/utils/lodash-mixins/lang');
+const { lodashObjectMixin } = require('ui/utils/lodash-mixins/object');
+const { lodashCollectionMixin } = require('ui/utils/lodash-mixins/collection');
+const { lodashFunctionMixin } = require('ui/utils/lodash-mixins/function');
+const { lodashOopMixin } = require('ui/utils/lodash-mixins/oop');
+
+lodashStringMixin(_);
+lodashLangMixin(_);
+lodashObjectMixin(_);
+lodashCollectionMixin(_);
+lodashFunctionMixin(_);
+lodashOopMixin(_);
+
 module.exports = _;