Remaining default to named conversions in ui/public #11323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this |
And turned on the eslint rule for that folder.
stacey-gammon
changed the title
pickypg
requested changes
Apr 20, 2017
| @@ -29,7 +29,8 @@ require('./vis'); | |||
| SavedObjectRegistryProvider.register(require('plugins/timelion/services/saved_sheet_register')); | |||
|
|
|||
| // TODO: Expose an api for dismissing notifications | |||
| const unsafeNotifications = require('ui/notify').default._notifs; | |||
| import { notify } from 'ui/notify'; | |||
There was a problem hiding this comment.
Are we okay with middle-of-the-file imports?
There was a problem hiding this comment.
moved to the top!
| require('ui/utils/lodash-mixins/function')(_); | ||
| require('ui/utils/lodash-mixins/oop')(_); | ||
| const _ = require('node_modules/lodash/index.js').runInContext(); | ||
| const { lodashStringMixin } = require('ui/utils/lodash-mixins/string'); |
There was a problem hiding this comment.
I believe this file is excluded from the babel transformation so if I make them imports, I get errors:
ERROR in ./webpackShims/lodash.js
Module parse failed: /Users/staceygammon/Elastic/kibana/webpackShims/lodash.js Line 10: Unexpected token
You may need an appropriate loader to handle this file type.
thomasneirynck
approved these changes
Apr 20, 2017
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 20, 2017
* use named ui-modules * x-pack conversion is checked in so no need for the default uiModules export * Final removal of all export default in ui/public And turned on the eslint rule for that folder. * Moe import to top of file
stacey-gammon
added a commit
that referenced
this pull request
Apr 20, 2017
…11351) * Remaining default to named conversions in ui/public (#11323) * use named ui-modules * x-pack conversion is checked in so no need for the default uiModules export * Final removal of all export default in ui/public And turned on the eslint rule for that folder. * Moe import to top of file * Convert remaining default exports in 5.x to get tests passing with the new rule
hickeyma
added a commit
to hickeyma/kibana
that referenced
this pull request
Apr 28, 2017
Some changes required to merge witth PRs: - elastic#11352 - elastic#11323
sivasamyk
added a commit
to sivasamyk/logtrail
that referenced
this pull request
Jul 8, 2017
…ibana moved exports of certain ui modules. Check elastic/kibana#11323 for more info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #11220
Switching over remaining modules to named and remove all default references.