Decode file name on upload value lists and fix bug with removing value list #111838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkhristinin
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
Author
|
@elasticmachine merge upstream |
rylnd
approved these changes
Sep 10, 2021
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Approving as-is since the code's 
, but let's please add a translation for the list item descriptions before we merge this.
x-pack/plugins/lists/server/services/items/write_lines_to_bulk_list_items.test.ts
Outdated
Show resolved
Hide resolved
| if (listId == null) { | ||
| list = await createListIfItDoesNotExist({ | ||
| description: `File uploaded from file system of ${fileNameEmitted}`, | ||
| description: `File uploaded from file system of ${fileName}`, |
Contributor
There was a problem hiding this comment.
While we're here we should probably add i18n for this string; see something like this for examples of using values with i18n.
Contributor
Author
|
@elasticmachine merge upstream |
…_list_items.test.ts Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 14, 2021
…e list (elastic#111838) * Decode fileName when creating a list * Return wait_for for delete list item * Return back import * Update x-pack/plugins/lists/server/services/items/write_lines_to_bulk_list_items.test.ts Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * Use i18n for message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 14, 2021
…e list (#111838) (#112056) * Decode fileName when creating a list * Return wait_for for delete list item * Return back import * Update x-pack/plugins/lists/server/services/items/write_lines_to_bulk_list_items.test.ts Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * Use i18n for message Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
nkhristinin
added
release_note:fix
and removed
release_note:skip
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Linked to #93346
wait_forfor deleting the list, fixing the bug, when the deleted list doesn't disappear from the table.The bug video
https://user-images.githubusercontent.com/7609147/132836105-5f904c56-7304-4748-86bf-9ffda2eaae34.movInitially, we added
wait_foron this PR.But then on this migration, it was changed to
false.It should be safe now to return it back to
wait_for.Checklist
Delete any items that are not applicable to this PR.
For maintainers