-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Description
Kibana version:
8.0.0
Describe the bug:
When importing value lists through the UI, the file is uploaded and the filename is URI encoded during the upload. The filename is then used as the value list ID, however the filename is not URI decoded before being stored, thus a filename that includes quotes like "Untitled".txt is stored as %22Untitled%22.txt. Since it's stored this way, when it comes back to the UI it's displayed in this encoded form as well.
Steps to reproduce:
- Upload a value list with one or more quotes in the filename
- Observe that the quotes are replaced with
%22when viewing the value list in the UI
Expected behavior:
Quotes should be preserved in the filename.
We likely need to add a call to decodeURIComponent on this line, however we should also ensure that these IDs are properly escaped when used in other places - particularly for generating KQL queries. This PR addresses some places where IDs were being used without escaping, but there could be others.