Skip to content

Conversation

@timroes
Copy link
Contributor

@timroes timroes commented Jul 7, 2021

Summary

Fixes #103751
Fixes #103749

Lower the limit of some of the App bundles that still had a limit above 100kB to be below 100k (the bundles were already below that size).

@timroes timroes added chore Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Jul 7, 2021
@timroes timroes requested a review from a team as a code owner July 7, 2021 16:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 7, 2021
@flash1293
Copy link
Contributor

Please don't close #103749 yet, I put some additional information in there to reduce the bundle size. I think that's still worth it.

@timroes
Copy link
Contributor Author

timroes commented Jul 7, 2021

@flash1293 I've extracted your comment into an own issue (#104697) to track lowering that bundle size, so we can close the one getting it below 100k, that's also linked in the meta issue.

@flash1293
Copy link
Contributor

Great thanks :)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit b5e22c9 into elastic:master Jul 8, 2021
@timroes timroes deleted the limits-lowering branch July 8, 2021 08:40
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 104688

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
timroes pushed a commit to timroes/kibana that referenced this pull request Jul 8, 2021
# Conflicts:
#	packages/kbn-optimizer/limits.yml
timroes pushed a commit that referenced this pull request Jul 8, 2021
# Conflicts:
#	packages/kbn-optimizer/limits.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[discover] Reduce page load bundle to under 100kB [charts] Reduce page load bundle to under 100kB

7 participants