Skip to content

Conversation

@darnautov
Copy link
Contributor

@darnautov darnautov commented Jul 7, 2021

Summary

Fixes #98649

Jul-07-2021 16-49-48

Note: The marker body gets aligned correctly only after resizing the page, cc @markov00

Checklist

@darnautov darnautov added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 7, 2021
@darnautov darnautov self-assigned this Jul 7, 2021
@darnautov darnautov requested a review from a team as a code owner July 7, 2021 14:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some small repositioning for labels at the right hand edge of the chart, but otherwise LGTM.

model_snapshot_label

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit d03922a into elastic:master Jul 7, 2021
@darnautov darnautov deleted the ml-fix-marker-positioning branch July 7, 2021 17:42
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 7, 2021
Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 8, 2021
…-of-max-results

* 'master' of github.com:elastic/kibana: (36 commits)
  Lower Kibana app bundle limits (elastic#104688)
  [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559)
  [RAC] Add mapping update logic to RuleDataClient (elastic#102586)
  Fix import workpad (elastic#104722)
  [canvas] Fix Storybook service decorator (elastic#104750)
  [Detection Rules] Add 7.14 rules (elastic#104772)
  [Enterprise Search] Fix beta notification in sidebar (elastic#104763)
  Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757)
  [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696)
  persistable state migrations (elastic#103680)
  [Fleet] Fix add agent in the package policy table (elastic#104749)
  [DOCS] Creates separate doc for security in production (elastic#103973)
  [SO Migration] fix reindex race on multi-instance mode (elastic#104516)
  [Security Solution] Update text in Endpoint Admin pages (elastic#104649)
  [package testing] Decrease timeout to 2 hours (elastic#104668)
  Fix background styling of waterfall chart sidebar tooltip. (elastic#103997)
  [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641)
  [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494)
  [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684)
  [ML] add marker body (elastic#104672)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/search_provider.test.ts
kibanamachine added a commit that referenced this pull request Jul 9, 2021
Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.14.0 v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ML] Fix date marker formatting in revert model snapshot flyout

4 participants