Skip to content

[User Experience] Move ux app to new nav #101005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2021
Merged

[User Experience] Move ux app to new nav #101005

merged 10 commits into from
Jun 4, 2021

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented May 31, 2021 •
edited
Loading

Summary

Fix #100859

The following considerations have been addressed

  • Accessibility has been considered, relevant aria tags and other accessibility features implemented
  • Telemetry has been added where relevant
  • Testing for expected behavior is in place
    • Automated tests exist to cover expected and edge case conditions
    • User acceptance testing has been carried out to ensure the feature functions as expected within the context of how it will be used
    • Any special/edge cases that need to be manually tested must be documented
    • Ensure the new layout works responsively (including down to small phone widths, where makes sense for the user flow, e.g. the error page when reacting to an alert)

image

@shahzad31 shahzad31 marked this pull request as ready for review June 1, 2021 13:33
@shahzad31 shahzad31 requested review from a team as code owners June 1, 2021 13:33
@shahzad31 shahzad31 self-assigned this Jun 1, 2021
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 1, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 1, 2021

Pinging @elastic/uptime (Team:uptime)

smith
smith requested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but since we're renaming these CSM files, we'll also need to update .github/CODEOWNERS and .github/paths-labeller.yml so it tags the right teams.

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 1, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 1, 2021

Pinging @elastic/apm-ui (Team:apm)

@shahzad31 shahzad31 requested a review from justinkambic June 3, 2021 13:26
@formgeist
Copy link
Contributor

formgeist commented Jun 3, 2021

@shahzad31 Noticed that the wrapping container is adding padding to the entire page template, which should be removed.

Screenshot 2021-06-03 at 16 16 05

@shahzad31 shahzad31 mentioned this pull request Jun 3, 2021
Merged
7 tasks
@shahzad31 shahzad31 requested a review from formgeist June 4, 2021 10:34
formgeist
formgeist approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

justinkambic
justinkambic approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and smoke test 👌

LGTM!

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 4, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 192 194 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -1.4KB
observability 466.7KB 454.0KB -12.8KB
uptime 1.1MB 1.1MB -268.0B
total -14.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 32.5KB 32.8KB +316.0B
observability 35.9KB 50.5KB +14.6KB
total +14.9KB
Unknown metric groups

API count

id before after diff
observability 192 194 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 76105cc into elastic:master Jun 4, 2021
@shahzad31 shahzad31 deleted the ux-new-nav branch June 4, 2021 16:04
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 4, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 4, 2021

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101005

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 7, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 7, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 101005 or prevent reminders by adding the backport:skip label.

@formgeist formgeist mentioned this pull request Jun 7, 2021
Closed
@shahzad31 shahzad31 mentioned this pull request Jun 8, 2021
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 8, 2021
shahzad31 added a commit that referenced this pull request Jun 8, 2021
@shahzad31
[User Experience] Move ux app to new nav (#101005) (#101575)
4970fa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smith smith smith approved these changes

@formgeist formgeist formgeist approved these changes

@justinkambic justinkambic justinkambic approved these changes

Assignees

@shahzad31 shahzad31

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Move User Experience (RUM) into the new navigation

6 participants

@shahzad31 @elasticmachine @formgeist @kibanamachine @smith @justinkambic