Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes OTEL] Add kubernetes OTEL package #11137

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Sep 16, 2024

Proposed commit message

Please explain:

  • WHAT: Add a new package - kubernetes OTEL of type content to ship assets for the EDOT installation
  • WHY: provide assets for the EDOT installation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2024-09-20 at 12 34 06 Screenshot 2024-09-20 at 12 34 19 Screenshot 2024-09-20 at 12 34 32

Tags:
Screenshot 2024-09-20 at 12 35 12

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested review from a team, gizas, constanca-m and MichaelKatsoulis and removed request for a team September 16, 2024 13:43
@@ -0,0 +1,3 @@
- text: OTEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to have a Kubernetes tag as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 default tags are Managed and the name of the integration:
Screenshot 2024-09-16 at 15 41 32
do you mean to add one more Kubernetes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rename OTEL -> OpenTelemetry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 531e6f8

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

💚 Build Succeeded

History

@tetianakravchenko tetianakravchenko merged commit 7c0518c into elastic:main Sep 20, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package kubernetes_otel - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=kubernetes_otel

"query": "\"metrics.k8s.node.cpu.usage\": *"
},
"isBucketed": false,
"label": "CPU usage Pct",
Copy link
Member

@ChrsMark ChrsMark Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dashboard finalized or just a work-in-progress/placeholder?
Just spotted that the specific Usage PCT label seems incorrect/confusing as noted at #10910 (comment). Is there any aggregation that calculates a ratio out of the usage metric?
Didn't check for other inconsistencies in that PR.

@AlexanderWert
Copy link
Member

@tetianakravchenko Does this PR replace the one in #10910 ?

If so, can we please make sure the comments @ChrsMark left there are considered here? Maybe in a followup PR?

@tetianakravchenko
Copy link
Contributor Author

tetianakravchenko commented Sep 23, 2024

@tetianakravchenko Does this PR replace the one in #10910 ?

@AlexanderWert @ChrsMark yes, it is planned for the followup PR, the whole list is in https://github.com/elastic/opentelemetry-dev/issues/454

@andrewkroh andrewkroh added the Integration:kubernetes_otel Kubernetes OpenTelemetry Assets label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:kubernetes_otel Kubernetes OpenTelemetry Assets New Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants