-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] K8s otel overview dashboard #10910
[Draft] K8s otel overview dashboard #10910
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💔 Build Failed
Failed CI StepsHistory
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments for alignment with the spec.
- Could we try to be consistent with the terminology, i.e.
usage
vsutilization
vspct
? Our panel titles etc should be aligned with the semantic convention definitions. Hence we should only useusage
orutilization
where it applies (no need forpct
,utilization
is a ratio anyways). - Could we consider leveraging the limits' utilization metrics as well? There was strong push-back by the community when we introduced the
*.node.utilization
metrics so relying only these might be risky in case the community decides to deprecate them. From my perspective these are nice to haves but we can rely to*.cpu.usage
ones and the limit based utilizations. - Also in the panels it would be nice if we explicitly mention what utilization we display (ratio against the node's capacity VS ratio against the limits).
"query": "\"metrics.k8s.node.cpu.usage\": *" | ||
}, | ||
"isBucketed": false, | ||
"label": "CPU usage Pct", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k8s.node.cpu.usage
metric represents the number of cores used in a time window, hence the term Pct is not accurate here. Or there is a specific reason for mentioning this?
"query": "\"metrics.k8s.pod.cpu.node.utilization\": *" | ||
}, | ||
"isBucketed": false, | ||
"label": "Pod CPU Usage ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this CPU utilization instead of usage? Also maybe you can consider explicitly mentioning that this utilization is against the Node's capacity and maybe add another graph for the limit based utilizations?
All comments were addressed in #11310, closing this PR |
Proposed commit message
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots
Current state:
TODO:
decisions: