-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix DNS lookup failure error for host URLs #449
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
CLA has now been signed. |
I wound up fixing this like this- |
That could be a great solution! |
I had an earlier PR that set this variable, you could resurrect it and trim it down to just this. Eventually I came to the conclusion that host networking was the easiest solution, but almost never the right one. That's not up to me though ;) |
Hi @FedeBev, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FedeBev, many thanks for this PR.
Sorry for the long delay for reviewing this PR.
Filebeat PR for hostNetwork
(#321) use only hostNetworking
value to manage both hostNetwork
and dnsPolicy
.
From what I see in Pod’s DNS Policy doc, the only relevant dnsPolicy
values are ClusterFirst
(default value) when hostNetwork
is disabled and ClusterFirstWithHostNet
when hostNetwork
is enabled.
Do you have some use case where you would need a different policy?
@FedeBev I created #585 to add host networking to Metricbeat while staying consistent with Filebeat. I'm sorry for making you wait so long then replacing your work due to bad timing. |
Hi @jmlrt, thank's for you work. I kept the options separate to leave maximum configuration flexibility. At the moment I can't image a situation where this is really required, so it's perfectly fine for me to keep that configuration in one option and #585 is perfect for my use case. Don't worry for the timing, luckily the workaround was very easy 😄 |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml
(Seems to be not required for current tests)This is a fix PR for #394 bug, feel free to suggest any other solution/idea.
Thanks