Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

use host networking for filebeat so that the stats have the correct n… #321

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

pbecotte
Copy link
Contributor

…ode information

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

matches changes I made to metricbeat to get hostnames reporting properly on Digital Ocean

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt jmlrt added the enhancement New feature or request label Oct 17, 2019
@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit a1dcddf into elastic:master Nov 21, 2019
@jmlrt jmlrt mentioned this pull request Dec 5, 2019
4 tasks
@jmlrt
Copy link
Member

jmlrt commented Dec 5, 2019

Hi @pbecotte,
We got an issue with this PR and Filebeat 7.5.0. The fact is that enabling hostNetwork by default fail our tests in 7.5.0 (and even if tests are OK with 7.4.2, we are not in a good state as filebeat reported an error of pod already used but didn't fail).

We also have use cases where hostNetwork is not possible (OpenShift for example).

FYI we'll have to disable hostNetwork by default and allow enabling it in by setting hostNetworking=true.

@pbecotte
Copy link
Contributor Author

pbecotte commented Dec 6, 2019

As I mentioned, I am not an elastic stack expert, so if that's necessary that's great :) It is important to mention though, without these changes nothing actually worked on digital ocean. Everything came up, but the metrics were all using container names as hostnames and none of the server level metrics were aggregating.

Would just ask to check that the metrics all look right with the changed config before making any decisions. The code that the comments implied were supposed to fix that didn't seem to work, and I iterated on it for a while before resorting to this approach.

@jmlrt
Copy link
Member

jmlrt commented Dec 6, 2019

FYI HostNetwork was disabled by default in 538af31. In your case where you need it, you'll just need to set HostNetworking: true in your values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants