Skip to content

[EuiButtonGroupButton] Make isSelected prop optional #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
+6 −45
Merged

[EuiButtonGroupButton] Make isSelected prop optional #9164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4208f8a
[EuiButtonGroupButton] Make isSelected prop optional
acstll Oct 31, 2025
47ea284
Changelog
acstll Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/eui/changelogs/upcoming/9164.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Bug fixes**

- Fixed internal `EuiButtonGroupButton` component so that `aria-pressed` can be omitted when necessary

43 changes: 0 additions & 43 deletions packages/eui/src/components/button/button_group/__snapshots__/button_group.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ exports[`EuiButtonGroup button props buttonSize compressed is rendered for multi
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-compressed-empty-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -36,7 +35,6 @@ exports[`EuiButtonGroup button props buttonSize compressed is rendered for multi
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-compressed-empty-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -58,7 +56,6 @@ exports[`EuiButtonGroup button props buttonSize compressed is rendered for multi
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-compressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -174,7 +171,6 @@ exports[`EuiButtonGroup button props buttonSize m is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-m-defaultMinWidth-euiButtonGroupButton-m-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -196,7 +192,6 @@ exports[`EuiButtonGroup button props buttonSize m is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-m-defaultMinWidth-euiButtonGroupButton-m-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -218,7 +213,6 @@ exports[`EuiButtonGroup button props buttonSize m is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-m-defaultMinWidth-isDisabled-euiButtonGroupButton-m-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -334,7 +328,6 @@ exports[`EuiButtonGroup button props buttonSize s is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -356,7 +349,6 @@ exports[`EuiButtonGroup button props buttonSize s is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -378,7 +370,6 @@ exports[`EuiButtonGroup button props buttonSize s is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -494,7 +485,6 @@ exports[`EuiButtonGroup button props color accent is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-accent-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -516,7 +506,6 @@ exports[`EuiButtonGroup button props color accent is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-accent"
data-test-subj="button01"
title="Option two"
Expand All @@ -538,7 +527,6 @@ exports[`EuiButtonGroup button props color accent is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -654,7 +642,6 @@ exports[`EuiButtonGroup button props color accentSecondary is rendered for multi
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-accentSecondary-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -676,7 +663,6 @@ exports[`EuiButtonGroup button props color accentSecondary is rendered for multi
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-accentSecondary"
data-test-subj="button01"
title="Option two"
Expand All @@ -698,7 +684,6 @@ exports[`EuiButtonGroup button props color accentSecondary is rendered for multi
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -814,7 +799,6 @@ exports[`EuiButtonGroup button props color danger is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-danger-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -836,7 +820,6 @@ exports[`EuiButtonGroup button props color danger is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-danger"
data-test-subj="button01"
title="Option two"
Expand All @@ -858,7 +841,6 @@ exports[`EuiButtonGroup button props color danger is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -974,7 +956,6 @@ exports[`EuiButtonGroup button props color primary is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-primary-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -996,7 +977,6 @@ exports[`EuiButtonGroup button props color primary is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-primary"
data-test-subj="button01"
title="Option two"
Expand All @@ -1018,7 +998,6 @@ exports[`EuiButtonGroup button props color primary is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1134,7 +1113,6 @@ exports[`EuiButtonGroup button props color success is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-success-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -1156,7 +1134,6 @@ exports[`EuiButtonGroup button props color success is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-success"
data-test-subj="button01"
title="Option two"
Expand All @@ -1178,7 +1155,6 @@ exports[`EuiButtonGroup button props color success is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1294,7 +1270,6 @@ exports[`EuiButtonGroup button props color text is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -1316,7 +1291,6 @@ exports[`EuiButtonGroup button props color text is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -1338,7 +1312,6 @@ exports[`EuiButtonGroup button props color text is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1454,7 +1427,6 @@ exports[`EuiButtonGroup button props color warning is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-warning-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -1476,7 +1448,6 @@ exports[`EuiButtonGroup button props color warning is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-empty-warning"
data-test-subj="button01"
title="Option two"
Expand All @@ -1498,7 +1469,6 @@ exports[`EuiButtonGroup button props color warning is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1615,7 +1585,6 @@ exports[`EuiButtonGroup button props isDisabled is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled-euiTestCss"
data-test-subj="test subject string"
disabled=""
Expand All @@ -1638,7 +1607,6 @@ exports[`EuiButtonGroup button props isDisabled is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button01"
disabled=""
Expand All @@ -1661,7 +1629,6 @@ exports[`EuiButtonGroup button props isDisabled is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1780,7 +1747,6 @@ exports[`EuiButtonGroup button props isFullWidth is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -1802,7 +1768,6 @@ exports[`EuiButtonGroup button props isFullWidth is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -1824,7 +1789,6 @@ exports[`EuiButtonGroup button props isFullWidth is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -1940,7 +1904,6 @@ exports[`EuiButtonGroup button props isIconOnly is rendered for multi 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton euiButtonGroupButton-isIconOnly testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-iconOnly-s-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -1962,7 +1925,6 @@ exports[`EuiButtonGroup button props isIconOnly is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton euiButtonGroupButton-isIconOnly emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-iconOnly-s-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -1984,7 +1946,6 @@ exports[`EuiButtonGroup button props isIconOnly is rendered for multi 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton euiButtonGroupButton-isIconOnly emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-iconOnly-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -2144,7 +2105,6 @@ exports[`EuiButtonGroup type="multi" idToSelectedMap 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down Expand Up @@ -2182,7 +2142,6 @@ exports[`EuiButtonGroup type="multi" renders 1`] = `
>
<button
aria-label="aria-label"
aria-pressed="false"
class="euiButtonGroupButton testClass1 testClass2 emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text-euiTestCss"
data-test-subj="test subject string"
title="Option one"
Expand All @@ -2204,7 +2163,6 @@ exports[`EuiButtonGroup type="multi" renders 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-euiButtonGroupButton-s-uncompressed-base-text"
data-test-subj="button01"
title="Option two"
Expand All @@ -2226,7 +2184,6 @@ exports[`EuiButtonGroup type="multi" renders 1`] = `
</span>
</button>
<button
aria-pressed="false"
class="euiButtonGroupButton emotion-euiButtonDisplay-s-defaultMinWidth-isDisabled-euiButtonGroupButton-s-uncompressed-empty-disabled"
data-test-subj="button02"
disabled=""
Expand Down
4 changes: 2 additions & 2 deletions packages/eui/src/components/button/button_group/button_group_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const EuiButtonGroupButton: FunctionComponent<Props> = ({
id,
isDisabled,
isIconOnly,
isSelected = false,
isSelected,
label,
value, // Prevent prop from being spread
size,
Expand Down Expand Up @@ -158,7 +158,7 @@ const EuiButtonGroupButtonWithToolTip: FunctionComponent<
Pick<Props, 'toolTipContent' | 'toolTipProps'> & {
children: ReactElement;
wrapperCss: CSSInterpolation;
isSelected: boolean;
isSelected?: boolean;
}
> = ({ toolTipContent, toolTipProps, wrapperCss, isSelected, children }) => {
return toolTipContent ? (
Expand Down