[EuiButtonGroupButton] Make isSelected prop optional
#9164
Merged
+6
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
EuiButtonGroupis currently meant "for indicating selection only" (docs). But button groups could be used to handle independent intent (clicks), as in toolbars e.g. upload a file.Important
This PR does not affect
EuiButtonGroup, only the internalEuiButtonGroupButton.The PR makes the
isSelectedprop optional, so that thearia-pressedattribute is not always present as to indicate selection. Allowing different usages of buttons within button groups.Why are we making this change?
To enable other usages for
EuiButtonGroupButtonother than selection.Needed to improve accessibility in #9151.
Impact to users
🟢 No impact, internal change.
QA
EuiButtonGroupis not affected and works as before.Remove or strikethrough items that do not apply to your PR.
General checklist
Checked in both light and dark modesChecked in both MacOS and Windows high contrast modes(emulate forced colors if you do not have access to a Windows machine.)Checked in mobileChecked in Chrome, Safari, Edge, and FirefoxChecked for accessibility including keyboard-only and screenreader modesAdded documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesUpdated visual regression testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)