Skip to content

Avoid transport_worker thread in TransportBroadcastAction #98001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2023
Merged

Avoid transport_worker thread in TransportBroadcastAction #98001

merged 2 commits into from
Jul 27, 2023

Conversation

DaveCTurner
Copy link
Contributor

TransportBroadcastAction derivatives do work which scales as the
number of shards in the cluster, both during coordination and when
processing responses. We must therefore not do this work on
transport_worker threads.

Relates #97920

@DaveCTurner
Avoid transport_worker thread in TransportBroadcastAction
85c0c20 
`TransportBroadcastAction` derivatives do work which scales as the
number of shards in the cluster, both during coordination and when
processing responses. We must therefore not do this work on
`transport_worker` threads.

Relates elastic#97920
@DaveCTurner DaveCTurner added >bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.10.0 labels Jul 27, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

henningandersen
henningandersen approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 27, 2023
@DaveCTurner DaveCTurner merged commit 53e3e7f into elastic:main Jul 27, 2023
@DaveCTurner DaveCTurner deleted the 2023/07/27/TransportBroadcastAction-forking branch July 27, 2023 11:50
@DaveCTurner DaveCTurner restored the 2023/07/27/TransportBroadcastAction-forking branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen approved these changes

@original-brownbear original-brownbear Awaiting requested review from original-brownbear

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @henningandersen