Avoid transport_worker thread in TransportBroadcastByNodeAction #97920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TransportBroadcastByNodeAction` derivatives do work which scales as the number of shards in the cluster, both during coordination and when processing responses. We must therefore not do this work on `transport_worker` threads. Closes elastic#97914
DaveCTurner
added
>bug
:Distributed Indexing/Distributed
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Failures are apparently because we don't fork when handling responses from remote clusters, and we retrieve indices stats from the remote cluster in CCR. I opened #97922 to address that first. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 27, 2023
`TransportBroadcastAction` derivatives do work which scales as the number of shards in the cluster, both during coordination and when processing responses. We must therefore not do this work on `transport_worker` threads. Relates elastic#97920
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023/07/25/TransportBroadcastByNodeAction-forking
branch
DaveCTurner
added a commit
that referenced
this pull request
Jul 27, 2023
`TransportBroadcastAction` derivatives do work which scales as the number of shards in the cluster, both during coordination and when processing responses. We must therefore not do this work on `transport_worker` threads. Relates #97920
DaveCTurner
restored the
2023/07/25/TransportBroadcastByNodeAction-forking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportBroadcastByNodeActionderivatives do work which scales as thenumber of shards in the cluster, both during coordination and when
processing responses. We must therefore not do this work on
transport_workerthreads.Closes #97914