[ML] Support fields with commas in data frame analytics analyzed_fields #91710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where fields containing comma (`,`) in their name would result in error when the `_start` or `_explain` APIs are called. If the field was `comma,field` for example, we would split the field into two tokens `comma` and `field` and thus the error would be that those fields could not be detected in the source index. Closes elastic#72541
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @dimitris-athanasiou, I've created a changelog YAML for you. |
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 18, 2022
…ds (elastic#91710) This commit fixes a bug where fields containing comma (`,`) in their name would result in error when the `_start` or `_explain` APIs are called. If the field was `comma,field` for example, we would split the field into two tokens `comma` and `field` and thus the error would be that those fields could not be detected in the source index. Closes elastic#72541
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Nov 18, 2022
…_fields This commit fixes a bug where fields containing comma (`,`) in their name would result in error when the `_start` or `_explain` APIs are called. If the field was `comma,field` for example, we would split the field into two tokens `comma` and `field` and thus the error would be that those fields could not be detected in the source index. Closes elastic#72541 Backport of elastic#91710
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2022
…ds (#91710) (#91716) This commit fixes a bug where fields containing comma (`,`) in their name would result in error when the `_start` or `_explain` APIs are called. If the field was `comma,field` for example, we would split the field into two tokens `comma` and `field` and thus the error would be that those fields could not be detected in the source index. Closes #72541
dimitris-athanasiou
deleted the
support-fields-with-commas-in-dfa-analyzed-fields
branch
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Nov 21, 2022
craigtaverner
added a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where fields containing comma (
,) in their name would result in error when the_startor_explainAPIs are called. If the field wascomma,fieldfor example, we would split the field into two tokenscommaandfieldand thus the error would be that those fields could not be detected in the source index.Closes #72541