Avoid NPE when disassociateDeadNodes is executed for a node present in the desired balance #91659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>bug
:Distributed Coordination/Allocation
Collaborator
|
Hi @idegtiarenko, I've created a changelog YAML for you. |
idegtiarenko
commented
Nov 17, 2022
...in/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceReconciler.java
Show resolved
Hide resolved
idegtiarenko
changed the title
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @idegtiarenko, I've updated the changelog YAML for you. |
DaveCTurner
approved these changes
Nov 18, 2022
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Could we assert the node is not-null in the place where the NPE was happening? Would have been good to see it as an immediate failure at that point, let's avoid any recurrence and document the assumption here.
Otherwise LGTM (one typo nit) no need for another review.
...in/java/org/elasticsearch/cluster/routing/allocation/allocator/DesiredBalanceReconciler.java
Outdated
Show resolved
Hide resolved
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Nov 18, 2022
…n the desired balance (elastic#91659)
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Nov 21, 2022
craigtaverner
added a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An NPE is thrown when executing
disassociateDeadNodesfor a node that ispresent in a desired balance failing corresponding master state update task.
As a result this node can no longer join cluster after restarting as it
remains in a cluster state.
Closes: #91517