Skip to content

[8.3] [ML] fixing bwc for trained model deployment inference (#88289) #88315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2022
Merged

[8.3] [ML] fixing bwc for trained model deployment inference (#88289) #88315

merged 3 commits into from
Jul 8, 2022

Conversation

benwtrent
Copy link
Member

Backports the following commits to 8.3:

@benwtrent
[ML] fixing bwc for trained model deployment inference (elastic#88289)
a6952ac 
When the internal objects were renamed, an inappropriate bwc version restriction was put in place.

This commit fixes this by allowing trained model assignment metadata updates to be serialized to nodes > 8.0.0.

This is OK as the object serialization handles its BWC conditions when serializing over the wire.

This closes: elastic#87959
@benwtrent benwtrent added :ml Machine learning >bug >test Issues or PRs that are addressing/adding tests backport Team:ML Meta label for the ML team test-full-bwc Trigger full BWC version matrix tests labels Jul 6, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 6, 2022
Merged
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit 031a174 into elastic:8.3 Jul 8, 2022
@benwtrent benwtrent deleted the backport/8.3/pr-88289 branch July 8, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport >bug :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v8.3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwtrent @elasticmachine @elasticsearchmachine