[ML] fixing bwc for trained model deployment inference #88289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
>test
|
Pinging @elastic/ml-core (Team:ML) |
benwtrent
commented
Jul 5, 2022
| return Version.V_8_3_0; | ||
| return Version.V_8_0_0; |
There was a problem hiding this comment.
This prevents the object from being serialized to older nodes. Since we don't update the object metadata custom name until all nodes are upgraded now, it is OK to serialize to older nodes.
| assertInfer(modelId); | ||
| assertInfer(modelId); | ||
| // attempt inference on new and old nodes multiple times | ||
| for (int i = 0; i < 100; i++) { |
There was a problem hiding this comment.
Do we want to keep the 100 inferences here?
There was a problem hiding this comment.
@dimitris-athanasiou we do not, I will reduce it to 10.
benwtrent
commented
Jul 6, 2022
...qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/MLModelDeploymentsUpgradeIT.java
Outdated
Show resolved
Hide resolved
…ades/MLModelDeploymentsUpgradeIT.java
dimitris-athanasiou
approved these changes
Jul 6, 2022
Did we backport the "don't rename until all nodes are upgraded" change to 8.3? |
Yes, in #87822. |
benwtrent
added
v8.3.3
auto-backport
|
@elasticmachine update branch |
💚 Backport successful
|
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jul 6, 2022
When the internal objects were renamed, an inappropriate bwc version restriction was put in place. This commit fixes this by allowing trained model assignment metadata updates to be serialized to nodes > 8.0.0. This is OK as the object serialization handles its BWC conditions when serializing over the wire. This closes: elastic#87959
benwtrent
added a commit
that referenced
this pull request
Jul 8, 2022
When the internal objects were renamed, an inappropriate bwc version restriction was put in place. This commit fixes this by allowing trained model assignment metadata updates to be serialized to nodes > 8.0.0. This is OK as the object serialization handles its BWC conditions when serializing over the wire. This closes: #87959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the internal objects were renamed, an inappropriate bwc version restriction was put in place.
This commit fixes this by allowing trained model assignment metadata updates to be serialized to nodes > 8.0.0.
This is OK as the object serialization handles its BWC conditions when serializing over the wire.
This closes: #87959