-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Generate release notes for v8.3.0 #87294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted some suggestions around formatting issues in the migration page
960ce34
to
b6b8d05
Compare
Including extracting static content from migration/index, so the template would be as light as possible. The reason for this work is because the gradle task `generateReleaseNotes` was not correctly adding new links and imports to the migrations/index and that caused documentation to fail building for 8.3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the ml-cpp PRs from https://github.com/elastic/ml-cpp/blob/8.3/docs/CHANGELOG.asciidoc and the overall layout LGTM, thanks!
* Generate release notes for v8.3.0 * [DOCS] Add 8.3 migration file to index * Fixed version number * Fix formatting of deprecation in 85326 * Use asciidoc format for deprecations * Extract static content from migration/index * This was just an enhancement * Nope, it was an upgrade * Added migration/index.asciidoc generation support (elastic#87318) Including extracting static content from migration/index, so the template would be as light as possible. The reason for this work is because the gradle task `generateReleaseNotes` was not correctly adding new links and imports to the migrations/index and that caused documentation to fail building for 8.3.0. * [DOCS] Add ml-cpp PRs to release notes * Added back incorrectly deleted changlog * Added missing highlight * Fixed spelling of StackOverflowError Co-authored-by: lcawl <lcawley@elastic.co>
* Generate release notes for v8.3.0 (#87294) * Generate release notes for v8.3.0 * [DOCS] Add 8.3 migration file to index * Fixed version number * Fix formatting of deprecation in 85326 * Use asciidoc format for deprecations * Extract static content from migration/index * This was just an enhancement * Nope, it was an upgrade * Added migration/index.asciidoc generation support (#87318) Including extracting static content from migration/index, so the template would be as light as possible. The reason for this work is because the gradle task `generateReleaseNotes` was not correctly adding new links and imports to the migrations/index and that caused documentation to fail building for 8.3.0. * [DOCS] Add ml-cpp PRs to release notes * Added back incorrectly deleted changlog * Added missing highlight * Fixed spelling of StackOverflowError Co-authored-by: lcawl <lcawley@elastic.co> * Brought back missing changelog for 87235 (#87370) * Brought back missing changelog for 87235 * Regenerate release notes * Regenerate release notes for BC3 (#87449) * Regenerate release notes for BC3 * Re-applied manual fixes that Lisa Cawley used * Fixed breaking changes generation To match the manual edits done by Lisa Cawley * Fixed failing test Since the manual edits by Lisa removed the `-SNAPSHOT` from the docs we remove it from the tests too. * Remove changelogs for intermediate lucene upgrades * Update release notes for BC4 (#87635) * Update release notes for BC4 * Adding missing changelog for geo_grid * Added missing highlight notes for 84250 * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> * Backported fixes to original yaml * Control sort order of release highlights So that small changes to an individual highlight don't completely shuffle the entire document. We also added links to the PRs from the highlight titles, for convenience. Otherwise readers need to search the release notes for the changelog entry and click there, which is a lot more work. * Fixed failing test after new ordered highlights Also made test verify re-ordering of highlights Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> * Update release notes for BC5 (#87808) * Update release notes for BC6 (#87912) * Update release notes for BC9 (#88011) * Regenerate release notes after version bump 8.4.0 And after forward porting 8.3.0 release notes changes. * Regenerate after some changelog entries removed * Re-prune the changelogs * Removed three changelog entries Co-authored-by: lcawl <lcawley@elastic.co> Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Once CI is complete the documentation will be available at:
https://elasticsearch_87294.docs-preview.app.elstc.co/diff