Skip to content

Brought back missing changelog for 87235 #87370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

craigtaverner
Copy link
Contributor

This is a backport of #87369 since that refers to the PR that was merged into 8.3.0.

While doing the release notes for 8.3.0 it was discovered that there was a PR 87016 with a missing changelog.

Investigation showed that this PR was merged (with changelog), reverted and the merged again (as a new PR with no changelog). It is not clear why the second time around the changelog was not added.

Original PR merged on 31st May 9c9bc87
Later that day the entire PR was reverted: 088af81
Then on the 1st June a new PR with the same content (minus the changelog) was merged (now in PR 87235): 64d716b

@craigtaverner craigtaverner added >docs General docs changes :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.3.0 labels Jun 3, 2022
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Jun 3, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@craigtaverner craigtaverner requested a review from lcawl June 3, 2022 15:06
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Docs LGTM

@craigtaverner craigtaverner merged commit a17ad4d into elastic:8.3 Jun 3, 2022
craigtaverner added a commit to craigtaverner/elasticsearch that referenced this pull request Jun 29, 2022
* Brought back missing changelog for 87235

* Regenerate release notes
craigtaverner added a commit that referenced this pull request Jun 30, 2022
* Generate release notes for v8.3.0 (#87294)

* Generate release notes for v8.3.0

* [DOCS] Add 8.3 migration file to index

* Fixed version number

* Fix formatting of deprecation in 85326

* Use asciidoc format for deprecations

* Extract static content from migration/index

* This was just an enhancement

* Nope, it was an upgrade

* Added migration/index.asciidoc generation support (#87318)

Including extracting static content from migration/index, so the template would be as light as possible.

The reason for this work is because the gradle task `generateReleaseNotes` was not correctly adding new links and imports to the migrations/index and that caused documentation to fail building for 8.3.0.

* [DOCS] Add ml-cpp PRs to release notes

* Added back incorrectly deleted changlog

* Added missing highlight

* Fixed spelling of StackOverflowError

Co-authored-by: lcawl <lcawley@elastic.co>

* Brought back missing changelog for 87235 (#87370)

* Brought back missing changelog for 87235

* Regenerate release notes

* Regenerate release notes for BC3 (#87449)

* Regenerate release notes for BC3

* Re-applied manual fixes that Lisa Cawley used

* Fixed breaking changes generation

To match the manual edits done by Lisa Cawley

* Fixed failing test

Since the manual edits by Lisa removed the `-SNAPSHOT` from the docs
we remove it from the tests too.

* Remove changelogs for intermediate lucene upgrades

* Update release notes for BC4 (#87635)

* Update release notes for BC4

* Adding missing changelog for geo_grid

* Added missing highlight notes for 84250

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Backported fixes to original yaml

* Control sort order of release highlights

So that small changes to an individual highlight don't completely shuffle the entire document.

We also added links to the PRs from the highlight titles, for convenience.
Otherwise readers need to search the release notes for the changelog entry and click there,
which is a lot more work.

* Fixed failing test after new ordered highlights

Also made test verify re-ordering of highlights

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update release notes for BC5 (#87808)

* Update release notes for BC6 (#87912)

* Update release notes for BC9 (#88011)

* Regenerate release notes after version bump 8.4.0

And after forward porting 8.3.0 release notes changes.

* Regenerate after some changelog entries removed

* Re-prune the changelogs

* Removed three changelog entries

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@craigtaverner craigtaverner deleted the 8.3-missing-changelog-87235 branch October 20, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.3.0 v8.3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants