You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dnhatn would you be able to add this setting to the deprecation API in a follow-up PR? That way users start getting notified about it sooner rather than later, and it lowers the chance that we forget about adding it at a later time.
I wonder if we actually should add it to the deprecation API. It doesn't hurt to have this setting set on old indices, it will just be ignored with this PR, and then archived once we effectively remove the setting. So not having it in the deprecation API could be a nicer user experience: less noise in the deprecation API and Elasticsearch takes care of the migration for existing indices?
Reading more about the migration API it looks like it's still expected to cover changes that users do not need to take action on, using the warning level instead of critical, as a way to convey information about the fact that the behavior will change in future versions. So I guess we need to add this setting there then.
…ed in v10
Introduce `Property.IndexSettingDeprecatedInV9AndRemovedInV10` property setting to mark
index settings that accepted on 9.x indices, but not on 10.0.
See elastic#80574, elastic#90264
See ES-11224
…ed in v10 (#124807)
Introduce `Property.IndexSettingDeprecatedInV9AndRemovedInV10` property setting to mark
index settings that accepted on 9.x indices, but not on 10.0.
See #80574, #90264
See ES-11224
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnhatn
added
>deprecation
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
This setting has been removed in Lucene 9.