Skip to content

[8.x] Remove index.merge.policy.max_merge_at_once_explicit deprecation #124792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Mar 13, 2025

This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning. This is an index setting and should have been marked as IndexSettingDeprecatedInV8AndRemovedInV9, but we can't change that in 8.x and will mark it as IndexSettingDeprecatedInV9AndRemovedInV10 in 9.0

See #80574, #90264
See ES-11224

@arteam arteam added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Mar 13, 2025
@arteam arteam added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.19.0 labels Mar 13, 2025
@arteam arteam force-pushed the max-merge-at-one-explicit-deprecated-warning branch from 4706fbf to 52f4b3e Compare March 13, 2025 18:01
@arteam arteam changed the title [8.x] Downgrade index.merge.policy.max_merge_at_once_explicit deprecation to a warning [8.x] Remove index.merge.policy.max_merge_at_once_explicit deprecation Mar 13, 2025
This setting is not getting removed in ES 9.0, so its usage should not generate a critical deprecation warning.
This is an index setting and should have been marked as `IndexSettingDeprecatedInV8AndRemovedInV9`, but we can't
change that in 8.x and will mark it as `IndexSettingDeprecatedInV9AndRemovedInV10` in 9.0

See elastic#90264
See ES-11224
@arteam arteam force-pushed the max-merge-at-one-explicit-deprecated-warning branch from 52f4b3e to 996d4ed Compare March 13, 2025 18:01
@arteam
Copy link
Contributor Author

arteam commented Mar 13, 2025

We could also mark it as DeprecatedWarning, but it believe it has no effect on index-scoped setting.

See https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/common/settings/AbstractScopedSettings.java#L570

@arteam arteam added v8.19.0 :Core/Infra/Settings Settings infrastructure and APIs labels Mar 13, 2025
@arteam arteam marked this pull request as ready for review March 13, 2025 20:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team labels Mar 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit f0f1869 into elastic:8.x Mar 14, 2025
16 checks passed
@arteam arteam deleted the max-merge-at-one-explicit-deprecated-warning branch March 14, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Settings Settings infrastructure and APIs :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue Team:Core/Infra Meta label for core/infra team Team:Distributed Indexing Meta label for Distributed Indexing team v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants