-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Allow deprecation warning for return_200_for_cluster_health_timeout
parameter
#80178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arteam
merged 1 commit into
elastic:master
from
arteam:allow-deprecated-parameter-warning
Nov 5, 2021
Merged
Allow deprecation warning for return_200_for_cluster_health_timeout
parameter
#80178
arteam
merged 1 commit into
elastic:master
from
arteam:allow-deprecated-parameter-warning
Nov 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut parameter It will be deprecated in elastic#78968, but first we need to backport the allow_warning change to 7.16 and 8.0 in order to not break BWC
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, David! |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 5, 2021
…ut parameter (elastic#80178) It will be deprecated in elastic#78968, but first we need to backport the allow_warning change to 7.16 and 8.0 in order to not break BWC
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 5, 2021
…ut parameter (elastic#80178) It will be deprecated in elastic#78968, but first we need to backport the allow_warning change to 7.16 and 8.0 in order to not break BWC
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…th_timeout parameter (elastic#80178) (elastic#80444)" This reverts commit 4102cf7.
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…th_timeout parameter (elastic#80178)" This reverts commit 1c711e3.
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…th_timeout parameter (elastic#80178) (elastic#80445)" This reverts commit 5a53007.
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
…ter/health` (#78180)" (#80831) * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)" This reverts commit 5a53007. * Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)" This reverts commit d8c1428 * Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)" This reverts commit 03bd55d
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
#78968)" (#80826) * [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)" This reverts commit 4102cf7. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562. * Revert "[8.0] Disable BWC for #80821 (#80840)"
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
)" (#80821) * Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178)" This reverts commit 1c711e3. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562 * Revert "Disable BWC for #80821 (#80839)" This reverts commit cb0e73e. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Distributed Indexing/CRUD
A catch all label for issues around indexing, updating and getting a doc by id. Not search.
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.16.0
v8.0.0-rc1
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be deprecated in #78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC