Skip to content

Allow deprecation warning for return_200_for_cluster_health_timeout parameter #80178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Nov 2, 2021

It will be deprecated in #78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC

…ut parameter

It will be deprecated in elastic#78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC
@arteam arteam added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.0.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. auto-backport Automatically create backport pull requests when merged v7.16.1 labels Nov 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arteam arteam merged commit 1c711e3 into elastic:master Nov 5, 2021
@arteam
Copy link
Contributor Author

arteam commented Nov 5, 2021

Thanks, David!

@arteam arteam deleted the allow-deprecated-parameter-warning branch November 5, 2021 18:27
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 5, 2021
…ut parameter (elastic#80178)

It will be deprecated in elastic#78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 5, 2021
…ut parameter (elastic#80178)

It will be deprecated in elastic#78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

arteam added a commit that referenced this pull request Nov 5, 2021
…ut parameter (#80178) (#80445)

It will be deprecated in #78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC
arteam added a commit that referenced this pull request Nov 5, 2021
…ut parameter (#80178) (#80444)

It will be deprecated in #78968, but first we need to backport the allow_warning
change to 7.16 and 8.0 in order to not break BWC
arteam added a commit that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
…ter/health` (#78180)" (#80831)

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)"

This reverts commit 5a53007.

* Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)"

This reverts commit d8c1428

* Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)"

This reverts commit 03bd55d
arteam added a commit that referenced this pull request Nov 18, 2021
#78968)" (#80826)

* [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)"

This reverts commit a2c3dae

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)"

This reverts commit 4102cf7.

* Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)"

This reverts commit b9fbe66.

* Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)"

This reverts commit f60bda5.

* Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)"

This reverts commit 8901a99

* Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)"

This reverts commit f266eb3

* Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)

This reverts commit fa4d562.

* Revert "[8.0] Disable BWC for #80821 (#80840)"
arteam added a commit that referenced this pull request Nov 18, 2021
)" (#80821)

* Revert "Return 200 OK response code for a cluster health timeout (#78968)"

This reverts commit a2c3dae

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178)"

This reverts commit 1c711e3.

* Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)"

This reverts commit b9fbe66.

* Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)"

This reverts commit f60bda5.

* Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)"

This reverts commit 8901a99

* Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)"

This reverts commit f266eb3

* Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)

This reverts commit fa4d562

* Revert "Disable BWC for #80821 (#80839)"

This reverts commit cb0e73e.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants