Skip to content

[7.x] Deprecate returning 408 for a server timeout on _cluster/health (#78180) #78940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Oct 11, 2021

Backports #78180 to 7.x.

Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0

Fixes #70849

…h` (elastic#78180)

Backports elastic#78180 to 7.x.

Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0

Fixes elastic#70849
@arteam arteam merged commit 03bd55d into elastic:7.x Oct 11, 2021
@arteam arteam deleted the backport-return-200-for-cluster-health-timeout branch October 12, 2021 08:48
@arteam arteam restored the backport-return-200-for-cluster-health-timeout branch October 12, 2021 09:10
arteam added a commit that referenced this pull request Oct 18, 2021
…uster health response code (#79351)

The original change was implemented in #78940, bu we have decided to move from a system property to an a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code.

Relates #70849
arteam added a commit to arteam/elasticsearch that referenced this pull request Oct 18, 2021
…new cluster health response code

Backport elastic#79351 to 7.x:

The original change was implemented in elastic#78940, but we have decided to move from a system property
to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code.

Relates elastic#70849
arteam added a commit that referenced this pull request Oct 18, 2021
…new cluster health response code (#79397)

Backport #79351 to 7.x:

The original change was implemented in #78940, but we have decided to move from a system property
to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code.

Relates #70849
arteam added a commit to arteam/elasticsearch that referenced this pull request Oct 19, 2021
…new cluster health response code (elastic#79397)

Backport elastic#79351 to 7.x:

The original change was implemented in elastic#78940, but we have decided to move from a system property
to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code.

Relates elastic#70849
DaveCTurner pushed a commit that referenced this pull request Oct 19, 2021
…new cluster health response code (#79397) (#79435)

Backport #79351 to 7.x:

The original change was implemented in #78940, but we have decided to move from a system property
to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code.

Relates #70849
arteam added a commit that referenced this pull request Nov 6, 2021
Returning 408 for a cluster health timeout was deprecated in #78180 and backported to 7.x in #78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes #70849
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 6, 2021
Returning 408 for a cluster health timeout was deprecated in elastic#78180 and backported to 7.x in elastic#78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes elastic#70849
arteam added a commit that referenced this pull request Nov 8, 2021
…0464)

Returning 408 for a cluster health timeout was deprecated in #78180 and backported to 7.x in #78940

Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.

Fixes #70849
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
…ter/health` (#78180)" (#80831)

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)"

This reverts commit 5a53007.

* Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)"

This reverts commit d8c1428

* Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)"

This reverts commit 03bd55d
@arteam arteam deleted the backport-return-200-for-cluster-health-timeout branch March 24, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants