-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[7.x] Deprecate returning 408 for a server timeout on _cluster/health
(#78180)
#78940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arteam
merged 1 commit into
elastic:7.x
from
arteam:backport-return-200-for-cluster-health-timeout
Oct 11, 2021
Merged
[7.x] Deprecate returning 408 for a server timeout on _cluster/health
(#78180)
#78940
arteam
merged 1 commit into
elastic:7.x
from
arteam:backport-return-200-for-cluster-health-timeout
Oct 11, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h` (elastic#78180) Backports elastic#78180 to 7.x. Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0 Fixes elastic#70849
This was referenced Oct 13, 2021
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 18, 2021
…new cluster health response code Backport elastic#79351 to 7.x: The original change was implemented in elastic#78940, but we have decided to move from a system property to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code. Relates elastic#70849
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 19, 2021
…new cluster health response code (elastic#79397) Backport elastic#79351 to 7.x: The original change was implemented in elastic#78940, but we have decided to move from a system property to a request parameter, so Cloud users/clients have an easier way to opt-in for the new status code. Relates elastic#70849
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 6, 2021
Returning 408 for a cluster health timeout was deprecated in elastic#78180 and backported to 7.x in elastic#78940 Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer. Fixes elastic#70849
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…er/health` (elastic#78180) (elastic#78940)" This reverts commit 03bd55d
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
…ter/health` (#78180)" (#80831) * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80445)" This reverts commit 5a53007. * Revert "[7.x] Use query param instead of a system property for opting in for new cluster health response code (#79397) (#79435)" This reverts commit d8c1428 * Revert "[7.x] Deprecate returning 408 for a server timeout on `_cluster/health` (#78180) (#78940)" This reverts commit 03bd55d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #78180 to 7.x.
Add a deprecation warning and a system property es.cluster_health.request_timeout_200 to opt in for returning 200 which will be the default in 8.0.0
Fixes #70849