Skip to content

[7.x] Update the mechanism for opting in for new cluster health timeout behaviour #79130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Oct 14, 2021

The original change was implemented in #78940, bu we have decided to move from a system property to an a request parameter, so Cloud users have an easier way to opt-in for the new status code.

@arteam arteam changed the title [7.x] Use settings instead of a system property for opting in for new cluster health response code [7.x] Update the mechanism for opting in for new cluster healh timeout response code Oct 14, 2021
@arteam arteam changed the title [7.x] Update the mechanism for opting in for new cluster healh timeout response code [7.x] Update the mechanism for opting in for new cluster health timeout behaviour Oct 14, 2021
@arteam arteam force-pushed the cluster-health-timeout-use-settings-instead-of-property branch 2 times, most recently from e214ed4 to 2af047d Compare October 14, 2021 09:44
@arteam arteam added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Oct 14, 2021
@arteam arteam marked this pull request as ready for review October 14, 2021 10:43
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 14, 2021
@arteam
Copy link
Contributor Author

arteam commented Oct 17, 2021

@elasticmachine update branch

@arteam arteam requested a review from DaveCTurner October 18, 2021 10:49
@arteam arteam marked this pull request as draft October 18, 2021 11:00
…uster health response code

Use query parameter instead of a setting

Use boolean parameter instead of settings

Rename to clusterHealthRequestTimeout200

Check serialization of isRequestTimeout

Check for parsing request_timeout_200 param

Update parameter name with a more clear name

Update the REST API spec

Document migration

Fix checkstyle errors
@arteam arteam force-pushed the cluster-health-timeout-use-settings-instead-of-property branch from 61d8598 to f0b7f99 Compare October 18, 2021 11:04
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Oct 18, 2021
@arteam
Copy link
Contributor Author

arteam commented Oct 18, 2021

@elasticmachine run elasticsearch-ci/part-2

@arteam arteam removed the request for review from DaveCTurner October 18, 2021 13:18
@arteam arteam marked this pull request as ready for review October 18, 2021 14:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@arteam arteam requested a review from DaveCTurner October 18, 2021 14:45
@arteam arteam closed this Oct 18, 2021
@arteam arteam deleted the cluster-health-timeout-use-settings-instead-of-property branch October 18, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Clients Meta label for clients team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants