Honour max segment size when setting only_expunge_deletes on force merge #77478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the es merge policy to apply the maximum segment size on force merges that only expunge deletes (forceMergeDeletes). This option is useful for read-write use cases that wants to reclaim deleted docs more aggressively than the `index.merge.policy.deletes_pct_allowed`. Relates elastic#77270
jimczi
added
>enhancement
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
jpountz
approved these changes
Sep 10, 2021
jimczi
added a commit
that referenced
this pull request
Sep 14, 2021
…rge (#77478) (#77692) This commit changes the es merge policy to apply the maximum segment size on force merges that only expunge deletes (forceMergeDeletes). This option is useful for read-write use cases that wants to reclaim deleted docs more aggressively than the `index.merge.policy.deletes_pct_allowed`. Closes #61764 Relates #77270
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the es merge policy to apply the maximum segment size
on force merges that only expunge deletes (forceMergeDeletes).
This option is useful for read-write use cases that wants to reclaim deleted docs
more aggressively than the
index.merge.policy.deletes_pct_allowed.For the backport in 7.x my plan is to apply this new behavior only if
max_num_segmentsis not set in the request ( #44761 to see why it's not an issue in ES 8x).Closes #61764
Relates #77270