Skip to content

[7.x] Exclude invalid url-encoded strings from randomized tests (#71085) #74039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danhermann
Copy link
Contributor

The randomized testing framework produces some input strings that are not valid URL-encoded strings so the URLDecodeProcessor correctly throws an exception. This change retries any tests that use a string that cannot be URL decoded.

Fixes #71077.

Backport of #71085

@danhermann danhermann added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP backport v7.14.0 labels Jun 11, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann danhermann merged commit ec71240 into elastic:7.x Jun 16, 2021
@danhermann danhermann deleted the backport_7x_71085_fix_url_encode_tests branch June 16, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants