Exclude invalid url-encoded strings from randomized tests #71085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>test
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
martijnvg
reviewed
Mar 31, 2021
| processor.execute(ingestDocument); | ||
| assertThat(ingestDocument.getFieldValue(targetFieldName, expectedResultType()), equalTo(expectedResult(fieldValue))); | ||
| } | ||
|
|
||
| protected boolean isSupportedValue(Object value) { | ||
| return false; |
There was a problem hiding this comment.
I think the default should return true here? Because now if this method isn't overwritten, the do-while loop never ends (i think this is why the some of these test fail).
There was a problem hiding this comment.
Yep, thanks. I renamed the isSupportedValue method from isUnsupportedValue but forgot to change the default return value. 🤦♂️
|
@elasticmachine update branch |
danhermann
deleted the
71077_urldecodeprocessortests_testtargetfield_failure
branch
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
May 20, 2021
danhermann
added a commit
that referenced
this pull request
May 20, 2021
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Jun 11, 2021
danhermann
added a commit
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The randomized testing framework produces some input strings that are not valid URL-encoded strings so the URLDecodeProcessor correctly throws an exception. This change retries any tests that use a string that cannot be URL decoded.
Fixes #71077.