Skip to content

SQL: Adapt the limitations page to the new "fields" API usage #69616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

SQL: Adapt the limitations page to the new "fields" API usage #69616

merged 2 commits into from
Mar 2, 2021

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 25, 2021

After #68802 was merged, this section of the SQL documentation needed an update.

@astefan astefan added :Analytics/SQL SQL querying >docs General docs changes labels Feb 25, 2021
@elasticmachine elasticmachine added Team:QL (Deprecated) Meta label for query languages team Team:Docs Meta label for docs team labels Feb 25, 2021
@astefan astefan requested a review from matriv February 25, 2021 16:17
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@astefan astefan requested a review from jrodewig February 25, 2021 16:17
jrodewig
jrodewig approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left two minor nits that are non-blocking. Thanks @astefan!

matriv
matriv approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan @jrodewig
Apply suggestions from code review
2939699 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@astefan astefan merged commit bf1b7a3 into elastic:master Mar 2, 2021
@astefan astefan added the v7.13.0 label Mar 2, 2021
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 2, 2021
@astefan @jrodewig
SQL: Adapt the limitations page to the new "fields" API usage (elasti…
e691678 
…c#69616)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
(cherry picked from commit bf1b7a3)
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 2, 2021
@astefan @jrodewig
SQL: Adapt the limitations page to the new "fields" API usage (elasti…
905a199 
…c#69616)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
(cherry picked from commit bf1b7a3)
astefan added a commit that referenced this pull request Mar 2, 2021
@astefan @jrodewig
SQL: Adapt the limitations page to the new "fields" API usage (#69616) (
ec28924 
#69815)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
(cherry picked from commit bf1b7a3)
astefan added a commit that referenced this pull request Mar 2, 2021
@astefan @jrodewig
SQL: Adapt the limitations page to the new "fields" API usage (#69616) (
e8b512d 
#69814)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
(cherry picked from commit bf1b7a3)
@astefan astefan deleted the fields_api_in_ql_docs_update branch March 2, 2021 15:45
@jrodewig jrodewig mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.12.0 v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@astefan @elasticmachine @matriv @jrodewig @jakelandis