QL: "fields" api implementation in QL #68802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ql_fields_api_implementation
…o ql_fields_api_implementation
…-flattened structure (#68745)
…stic/elasticsearch into ql_fields_api_implementation
astefan
added
>enhancement
>breaking
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
1 similar comment
|
Pinging @elastic/es-ql (Team:QL) |
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Feb 10, 2021
* Integrate "fields" API into QL (elastic#68467) * QL: retry SQL and EQL requests in a mixed-node (rolling upgrade) cluster (elastic#68602) * Adapt nested fields extraction from "fields" API output to the new un-flattened structure (elastic#68745) (cherry picked from commit ee5cc54)
This was referenced Feb 17, 2021
Closed
34 tasks
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change achieves witching from using
docvalue_fieldsand_sourceextraction to using thefieldsAPI. It helps simplify the QL code, but does also come with a small drawback which will become visible inFieldHitExtractorTestswhere some tests are not needed anymore. Any query (especially SQL) on fields that have_sourcedisabled, but are indexed (accessible throughdocvalue_fields), will not be possible anymore.This PR, also, improves bwc checks when it comes to running queries in a mixed-versions cluster (a rolling upgrade scenario) by using a minimum compatibility version when creating a search request against ES and re-trying the request if the search proves to be executed on at least one incompatible shard. The retrial happens on a node that has an older version, the original request (SQL/EQL request) being sent through transport layer. The node receiving the retried request will re-parse it and create another query DSL to be sent to ES.
Addresses #67727.
PRs in this merge:
#68467
#68602
#68745