Drop single node test case from runtime fields #61241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the `ESSingleNodeTestCase` with `ESTestCase` in runtime fields, proving that we can use `ESTestCase` to test field mappers.
nik9000
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
javanna
reviewed
Aug 18, 2020
| MAPPER_REGISTRY, | ||
| () -> { throw new UnsupportedOperationException(); }, | ||
| () -> true, | ||
| SCRIPT_SERVICE |
There was a problem hiding this comment.
One thing I can't wrap my head around: as it stands this depends on #60933 . There is no final agreement yet on how to expose script service to the mappings code, so I was wondering whether it's wise to build on that, or whether we would still be able to adapt the test code once we find an alternative solution that we have agreement on.
There was a problem hiding this comment.
I think we can adapt it to whatever we decide on, yeah.
javanna
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
ESSingleNodeTestCasewithESTestCasein runtimefields, proving that we can use
ESTestCaseto test field mappers.Relates to #59332