Add the ScriptService to the field parser config #60933
Conversation
This makes parsing runtime fields much simpler.
nik9000
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
@romseygeek I've opened this one against the runtime fields branch which lets me verify that it solves my problems. If you like it I'd like to cherry pick it over to master and 7.x. |
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
Huh, that was easier than I was expecting it to be. I left one grammar nit, other than that LGTM. I'm fine with this staying in the runtime fields branch for now, better to have something that actually uses the ScriptService when it's added.
| protected Function<String, SimilarityProvider> similarityLookupService() { return similarityLookupService; } | ||
|
|
||
| /** | ||
| * The {@linkplain ScriptService} to compile scripts needs by the {@linkplain Mapper}. |
Sure! If we start to see a bunch of merge conflicts I might bring this up again! |
|
Thanks @romseygeek ! |
| match: | ||
| animal: cow | ||
| - match: {hits.total.value: 1} | ||
| - match: {hits.hits.0._source.animal: cow} |
There was a problem hiding this comment.
I was wondering if it would be possible to have some other way of testing this besides a yaml test, a single node test would also be good I think
4 participants
This makes parsing runtime fields much simpler.
We'd initially resisted doing this but all of our other integration options
proved more troublesome.