Skip to content

Add More Trace Logging to BlobStoreRepository #56336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

original-brownbear
Copy link
Contributor

Adding more trace logging that would be helpful in understanding
the precise order of blob-level operations if needed.

Adding more trace logging that would be helpful in understanding
the precise order of blob-level operations if needed.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 7, 2020
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; there's other places we interact with the repo that might be worth tracing too, e.g. the calls to ChecksumBlobStoreFormat#write in finalizeSnapshot.

@original-brownbear
Copy link
Contributor Author

Thanks David!

there's other places we interact with the repo that might be worth tracing too

Right, good point. I'll add some logging to the finalization in a follow-up. I have a PR in the pipeline that makes changes to that shortly anyway :)

@original-brownbear original-brownbear merged commit 787c12a into elastic:master May 8, 2020
@original-brownbear original-brownbear deleted the log-more-inblob-store branch May 8, 2020 05:40
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request May 8, 2020
Adding more trace logging that would be helpful in understanding
the precise order of blob-level operations if needed.
original-brownbear added a commit that referenced this pull request May 8, 2020
Adding more trace logging that would be helpful in understanding
the precise order of blob-level operations if needed.
@original-brownbear original-brownbear restored the log-more-inblob-store branch August 6, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants