Fix Noisy Logging during Snapshot Delete (#56264) #56329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were logging the cleanup of the snap- and meta- blobs for every snapshot delete which is needlessly noisy and confusing to users. We should only log actual stale/unexpected blobs here.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
elasticmachine
added
the
Team:Distributed (Obsolete)
DaveCTurner
approved these changes
May 7, 2020
| if (blobsToDelete.isEmpty()) { | ||
| return blobsToDelete; | ||
| } | ||
| try { | ||
| logger.info("[{}] Found stale root level blobs {}. Cleaning them up", metadata.name(), blobsToDelete); | ||
| if (logger.isInfoEnabled()) { |
There was a problem hiding this comment.
I think it would be helpful to continue to log all the blobs at TRACE level; I'd do both if there are unexpected ones as it's interesting to know that they were unexpected.
There was a problem hiding this comment.
D'oh just spotted this was a backport and already approved in master, sorry 😕
There was a problem hiding this comment.
No worries, I'll do a follow-up for this shortly, I wanted to add some other trace logging as well anyway :)
There was a problem hiding this comment.
#56336 :)
|
Jenkins run elasticsearch-ci/bwc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were logging the cleanup of the snap- and meta- blobs for every snapshot delete
which is needlessly noisy and confusing to users. We should only log actual stale/unexpected
blobs here.