Centralize BoundingBox logic to a dedicated class #50253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both geo_bounding_box query and geo_bounds aggregation have a very similar definition of a "bounding box". A lot of this logic (serialization, xcontent-parsing, etc) can be centralized instead of having separated efforts to do the same things
talevy
added
the
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
|
run elasticsearch-ci/1 |
|
aborted build for the upgrade, jenkins test this please |
|
run elasticsearch-ci/default-distro |
nknize
suggested changes
Dec 18, 2019
server/src/main/java/org/elasticsearch/common/geo/BoundingBox.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/common/geo/BoundingBoxTests.java
Outdated
Show resolved
Hide resolved
|
thanks for the review Nick, I've renamed the class! |
|
@elasticmachine update branch |
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Both geo_bounding_box query and geo_bounds aggregation have a very similar definition of a "bounding box". A lot of this logic (serialization, xcontent-parsing, etc) can be centralized instead of having separated efforts to do the same things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both geo_bounding_box query and geo_bounds aggregation have
a very similar definition of a "bounding box". A lot of this
logic (serialization, xcontent-parsing, etc) can be centralized
instead of having separated efforts to do the same things
relates to #50002 where yet another
boundscontext is to beintroduced in the geo*_grid aggregations.