[GEO] Consolidate duplicate Bounding Box classes

[nknize]

Aggregations, Filters, Builders all have some form of a Bounding Box implementation. This task is to consolidate all of these duplicate "rogue" classes into one (possibly in GeoUtils).

Note: this consolidation could eventually be replaced w/ an integration of the Apache SIS geometry package and using the Envelope geometry.

[clintongormley]

@MaineC has this been resolved by #11969 ?

[MaineC]

@clintongormley no, #11969 only touches the GeoBoundingBox_QueryBuilder_. What I believe @nknize is talking about is how bounding boxes are represented in general - though he'd have to comment on which classes he is referring to in particular. The two I found with a quick search github:

• Internal class of InternalGeoBounds
• Two points in GeoBoundingBoxQueryBuilder

[nknize]

There's also 2 BoundingBox classes within Lucene.

The full objective is to refactor all geometry logic out of elasticsearch and into lucene. This issue starts small by simply consolidating all of the different bounding box classes.

[adamrmelnyk]

Are you still looking to make this change? I did a quick search but only came up with those two classes. Did you mean you wanted to make this an inner class in GeoUtils or just under commons/geo?

[Shubhangi2901]

Hi @nknize if this issue is still open i would like to work on this! :)

[abprash]

Hi @Shubhangi2901 , mind if i take a shot at this? :)

[Shubhangi2901]

Hi @abprash I have actually made some progress on it and am hoping to an initial commit soon. Once I push the update, if there are other big parts left, I'd love to collaborate if you'd like.

[abprash]

@Shubhangi2901 , sure, sounds good. Thanks!

[talevy]

I believe much of the parsing logic has been consolidated in GeoBoundingBox.parseBoundingBox in #50253.

How was your attempt at consolidating more of the code going @abprash and @Shubhangi2901?

[talevy]

Closing due to some latest cleanup and #50253