Deprecate get.json removed parameters in 7.x #41439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since these have been publicized on 7.0 we can no longer remove this Marking these as deprecated instead. relates to: elastic#38613
|
Pinging @elastic/es-core-infra |
|
I have just merged the same change as part of #42188 to 7.x, going to backport to other 7.x branches also, closing this one. |
|
Actually, not quite the same change... but I think removing those parameters is more correct as they are effectively no longer supported since 7.0. Thoughts @Mpdreamz ? |
Mpdreamz
added a commit
that referenced
this pull request
Jun 11, 2019
* Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Jun 11, 2019
…41444) * Documents the new deprecations options on the rest-api-spec Relates elastic#41439 elastic#38613 elastic#35262 * remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Jun 11, 2019
…41444) * Documents the new deprecations options on the rest-api-spec Relates elastic#41439 elastic#38613 elastic#35262 * remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
This was referenced Jun 11, 2019
Mpdreamz
added a commit
that referenced
this pull request
Jun 11, 2019
…43090) * Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
Mpdreamz
added a commit
that referenced
this pull request
Jun 11, 2019
…43089) * Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since these have been publicized on 7.0 we can no longer remove this
Marking these as deprecated instead.
relates to: #38613