Skip to content

get.json documents deprecated _source_include #38613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 8, 2019

This brings it inline with other REST spec files which only document the plural

cc @elastic/es-clients

This brings it inline with other REST spec files which only document the plural
@matriv matriv added >docs General docs changes :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Feb 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Mar 4, 2019

run elasticsearch-ci/1

@ywelsch
Copy link
Contributor

ywelsch commented Mar 4, 2019

@Mpdreamz can you merge latest master into this and give CI another run? Thank you

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates #33475

@Mpdreamz Mpdreamz added the :Core/Infra/REST API REST infrastructure and utilities label Mar 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@polyfractal polyfractal removed the v7.0.0 label Apr 9, 2019
@Mpdreamz Mpdreamz merged commit 125f589 into master Apr 23, 2019
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Apr 23, 2019
Since these have been publicized on 7.0 we can no longer remove this

Marking these as deprecated instead.

relates to: elastic#38613
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Apr 23, 2019
@javanna javanna removed the v7.2.0 label May 20, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This brings it inline with other REST spec files which only document the plural
Mpdreamz added a commit that referenced this pull request Jun 11, 2019
* Documents the new deprecations options on the rest-api-spec

Relates #41439 #38613 #35262

* remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Jun 11, 2019
…41444)

* Documents the new deprecations options on the rest-api-spec

Relates elastic#41439 elastic#38613 elastic#35262

* remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit to Mpdreamz/elasticsearch that referenced this pull request Jun 11, 2019
…41444)

* Documents the new deprecations options on the rest-api-spec

Relates elastic#41439 elastic#38613 elastic#35262

* remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit that referenced this pull request Jun 11, 2019
…43090)

* Documents the new deprecations options on the rest-api-spec

Relates #41439 #38613 #35262

* remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
Mpdreamz added a commit that referenced this pull request Jun 11, 2019
…43089)

* Documents the new deprecations options on the rest-api-spec

Relates #41439 #38613 #35262

* remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid

* removed one more instance of path

* make sure json examples are self contained and not excerpts

(cherry picked from commit 4430f99)
@colings86 colings86 deleted the rest-spec-get-json branch May 27, 2020 07:40
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants