Replace usages RandomizedTestingTask with built-in Gradle Test #40978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit puts a workaround in place for our existing test convention enforcement. The full-cluster-restart tests here are unique in that they include another test projects source in order to extend the test classes. The test conventions task isn't aware of this an fails due to these tests being excluded, but not run by any other task. We'll soon want to ditch the hack for a better method for sharing this kind of logic across projects anyhow, as this kind of thing won't work with newer versions of IntelliJ.
# Conflicts: # buildSrc/src/main/java/org/elasticsearch/gradle/testfixtures/TestFixturesPlugin.java # plugins/repository-hdfs/build.gradle # test/fixtures/hdfs-fixture/build.gradle # test/fixtures/krb5kdc-fixture/build.gradle # x-pack/qa/full-cluster-restart/build.gradle # x-pack/qa/rolling-upgrade/build.gradle
This reverts commit 33a5cd3
# Conflicts: # buildSrc/src/main/java/org/elasticsearch/gradle/testfixtures/TestFixturesPlugin.java # test/fixtures/hdfs-fixture/build.gradle
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Apr 9, 2019
…ic#40978) This commit replaces the existing RandomizedTestingTask and supporting code with Gradle's built-in JUnit support via the Test task type. Additionally, the previous workaround to disable all tasks named "test" and create new unit testing tasks named "unitTest" has been removed such that the "test" task now runs unit tests as per the normal Gradle Java plugin conventions. (cherry picked from commit 323f312)
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Apr 9, 2019
…ic#40978) This commit replaces the existing RandomizedTestingTask and supporting code with Gradle's built-in JUnit support via the Test task type. Additionally, the previous workaround to disable all tasks named "test" and create new unit testing tasks named "unitTest" has been removed such that the "test" task now runs unit tests as per the normal Gradle Java plugin conventions. (cherry picked from commit 323f312)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 9, 2019
* master: Use more targeted muting of failing SQL spec tests Mute failing SQL spec suites Mute testRecoverMissingAnalyzer [DOCS] Add notable-breaking-changes tags (elastic#40990) Replace usages RandomizedTestingTask with built-in Gradle Test (elastic#40978)
mark-vieira
added a commit
that referenced
this pull request
Apr 9, 2019
…Test (#40978) (#40993) * Replace usages RandomizedTestingTask with built-in Gradle Test (#40978) This commit replaces the existing RandomizedTestingTask and supporting code with Gradle's built-in JUnit support via the Test task type. Additionally, the previous workaround to disable all tasks named "test" and create new unit testing tasks named "unitTest" has been removed such that the "test" task now runs unit tests as per the normal Gradle Java plugin conventions. (cherry picked from commit 323f312) * Fix forking JVM runner * Don't bump shadow plugin version
mark-vieira
added a commit
that referenced
this pull request
Apr 9, 2019
… (#40995) This commit replaces the existing RandomizedTestingTask and supporting code with Gradle's built-in JUnit support via the Test task type. Additionally, the previous workaround to disable all tasks named "test" and create new unit testing tasks named "unitTest" has been removed such that the "test" task now runs unit tests as per the normal Gradle Java plugin conventions. (cherry picked from commit 323f312)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…ic#40978) This commit replaces the existing RandomizedTestingTask and supporting code with Gradle's built-in JUnit support via the Test task type. Additionally, the previous workaround to disable all tasks named "test" and create new unit testing tasks named "unitTest" has been removed such that the "test" task now runs unit tests as per the normal Gradle Java plugin conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #40564 after it was discovered that PR caused memory issues in CI. That PR was reverted so I am creating a new PR with fixes.