Skip to content

Fix command line to run doc tests in docs/README. #40959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Apr 8, 2019

It runs gradle instead of gradlew and has an extra \.

It runs `gradle` instead of `gradlew` and has an extra `\`.
@jpountz jpountz added >docs General docs changes :Delivery/Build Build or test infrastructure labels Apr 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @mark-vieira

@mark-vieira
Copy link
Contributor

This looks fine although after merging #40978 the preferred method is to use --tests but the old system properties technically do still work.

@jpountz
Copy link
Contributor Author

jpountz commented Apr 9, 2019

Happy to change it to use the preferred method. @mark-vieira do you mean it should be ./gradlew :docs:check --tests "*rollover*"?

@mark-vieira
Copy link
Contributor

mark-vieira commented Apr 9, 2019

@jpountz you have to pass --tests to the actual test task, so in the case the correct command would be:

./gradlew :docs:integTestRunner --tests "*rollover*"

Results in the following: https://scans.gradle.com/s/igdndll67mjuo/tests

@jpountz
Copy link
Contributor Author

jpountz commented Apr 10, 2019

👍

@jpountz jpountz merged commit b57965c into elastic:master Apr 10, 2019
@jpountz jpountz deleted the docs_readme branch April 10, 2019 09:15
jpountz added a commit that referenced this pull request Apr 10, 2019
It runs `gradle` instead of `gradlew` and has an extra `\`.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
It runs `gradle` instead of `gradlew` and has an extra `\`.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants